PKG -- [transport-grpc] Add blockId to transaction status #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
requested review from
JeffreyDoyle,
10thfloor,
gregsantos,
chasefleming and
justinbarry
as code owners
🦋 Changeset detectedLatest commit: cea93e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
JeffreyDoyle
requested changes
May 26, 2022
| payload: {type: "String", value: "Hello, Flow"} | ||
| } | ||
| ] | ||
| blockId: |
…end-get-block, update send-get-block unit test with collectionGuarantees
…ck-id-transport-grpc
…ck-id-transport-grpc
|
Just updating docs on this one and it will be ready to go |
jribbink
force-pushed
the
jribbink/block-id-transport-grpc
branch
from
689814d
to
ceb92b3
Compare
JeffreyDoyle
requested changes
Jun 1, 2022
| status: res.getStatus(), | ||
| statusString: STATUS_MAP[res.getStatus()], | ||
| statusCode: res.getStatusCode(), | ||
| errorMessage: res.getErrorMessage(), | ||
| events: events.map(event => ({ | ||
| type: event.getType(), | ||
| transactionId: u8ToHex(event.getTransactionId_asU8(), context), | ||
| transactionId: nonEmptyU8ToHex(event.getTransactionId_asU8(), context), |
There was a problem hiding this comment.
Is this ever empty? AFAIK events will always have a transactionId associated. I think we should use the old u8ToHex in this case?
JeffreyDoyle
approved these changes
Jun 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #1205