Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKG -- [protobuf] Update & regenerate protobuf definitions to match a… #1205

Merged
merged 3 commits into from
May 31, 2022
Merged

PKG -- [protobuf] Update & regenerate protobuf definitions to match a… #1205

merged 3 commits into from
May 31, 2022

Conversation

jribbink
Copy link
Contributor

…ccess nodes

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f7c7dc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink mentioned this pull request May 25, 2022
Merged
@JeffreyDoyle
Copy link
Member

Is this PR superseded by #1206?

@jribbink
Copy link
Contributor Author

Is this PR superseded by #1206?

The idea was to break it into two PRs so that when it got squashed and merged it would be broken into two commits

@jribbink
Copy link
Contributor Author

Something is not quite right with this one... don't merge yet I'm just investigating a little thing

@jribbink jribbink force-pushed the jribbink/update-protobuf-definitions branch from 721dfd6 to b89b44e Compare May 30, 2022 22:17
@jribbink
Regenerate protobuf files, add signerIds to collectionGuarantees in s…
5200655 
…end-get-block, update send-get-block unit test with collectionGuarantees
@jribbink jribbink force-pushed the jribbink/update-protobuf-definitions branch from b89b44e to 5200655 Compare May 30, 2022 22:26
@jribbink jribbink merged commit 9541835 into master May 31, 2022
@jribbink jribbink deleted the jribbink/update-protobuf-definitions branch May 31, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyDoyle JeffreyDoyle JeffreyDoyle approved these changes

@gregsantos gregsantos gregsantos approved these changes

@10thfloor 10thfloor Awaiting requested review from 10thfloor

@chasefleming chasefleming Awaiting requested review from chasefleming

@justinbarry justinbarry Awaiting requested review from justinbarry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jribbink @JeffreyDoyle @gregsantos