Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"block_id" is not available on transaction result response #926

Closed
2 tasks
MaxStalker opened this issue Dec 12, 2021 · 0 comments · Fixed by #1206
Closed
2 tasks

"block_id" is not available on transaction result response #926

MaxStalker opened this issue Dec 12, 2021 · 0 comments · Fixed by #1206
Assignees
Labels
Bug Something isn't working Feedback

Comments

@MaxStalker
Copy link
Contributor

MaxStalker commented Dec 12, 2021

Problem

Profobuf definition in flow repository have block_id field for TransactionResponseResult object, while one in fcl-js doesn't have it (

message TransactionResultResponse {
entities.TransactionStatus status = 1;
uint32 status_code = 2;
string error_message = 3;
repeated entities.Event events = 4;
}
)

As a result it's impossible to discover block, where transaction was included.

Solution

  • regenerate sdk files from new protobuf definitions
  • update the corresponding documentation
@MaxStalker MaxStalker added Bug Something isn't working Feedback labels Dec 12, 2021
@JeffreyDoyle JeffreyDoyle self-assigned this Dec 13, 2021
@justinbarry justinbarry assigned jribbink and unassigned JeffreyDoyle May 25, 2022
@jribbink jribbink linked a pull request May 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants