Memory metering #1653
Merged
Memory metering #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lint errors
Remove block memory kind
Atree 0.3.0 uses new versions of CBOR and CircleHash: - fxamacker/cbor [feature/stream-mode branch] to March 13 commit 12f5cb4b5eb0efcd590d323ff6a292a6d4f9e36c - fxamacker/circlehash from 0.2.0 to 0.3.0
Port bumping onflow/atree from 0.2.0 to 0.3.0
* Memory metering for boolean * Memory metering for nil * Memory metering for VoidValue * Memory metering for CharacterValue * Memory metering for TypeValue * memory metering for StorageReferenceValue * memory metering for EphemeralReferenceValue * memory metering for AddressValue * Clone() method does not need to meter memory * memory metering for PathValue * memory metering for LinkValue * use EmptyTypeValue where possible * UseConstantValue is now a function not a method * return NewNilValue instead of nil for bad paths * Add memory metering tests for importing simple types * AddressValue uses constant memory * add TODO for future TypeValue work * add many tests and some fixes * simplest script has Void as well as InterpretedFunction Co-authored-by: Bastian Müller <[email protected]> Co-authored-by: robert <[email protected]> Co-authored-by: Supun Setunga <[email protected]>
* address comments in prev PR * meter link creation when atree validation is off Co-authored-by: robert <[email protected]>
Refactor to meter address value before creation, whenever possible
…nto atreestringvalue-metering
atree string value metering
…adence into supun/fixed-numbers-metering
Check address length before decoding
Co-authored-by: Supun Setunga <[email protected]>
Sync memory metering branch with master
adjust big int metering minor errors
Memory meter static-type to sema-type conversion
…adence into supun/improve-metering
Improve memory metering
merge `master` into `memory-metering`
dsainati1
reviewed
May 16, 2022
| @@ -88,6 +88,19 @@ to the `prepare` phase of the transaction. | |||
|
|
|||
| let keys: AuthAccount.Keys | |||
|
|
|||
| // Key management | |||
There was a problem hiding this comment.
Is this supposed to include the public key API changes?
There was a problem hiding this comment.
This PR just reverts the removal of the deprecated functions. This documentation should have been added back to master already before, but it seems like it wasn't
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit bddd08f Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
reviewed
May 16, 2022
| @@ -85,6 +85,7 @@ func ByteValueToByte(element Value) (byte, error) { | |||
| return b, nil | |||
| } | |||
|
|
|||
| // TODO: meter | |||
There was a problem hiding this comment.
should be safe to remove this todo?
There was a problem hiding this comment.
There seem to be still some outstanding TODOs and PRs too:
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
+ Coverage 74.78% 76.45% +1.66%
==========================================
Files 288 291 +3
Lines 55418 60678 +5260
==========================================
+ Hits 41444 46389 +4945
- Misses 12481 12677 +196
- Partials 1493 1612 +119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dapperlabs/cadence-private-issues#36
Huge shout-out to @SupunS @dsainati1 @robert-e-davidson3 👏 👏 👏
masterbranchFiles changedin the Github PR explorer