Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bumping onflow/atree from 0.2.0 to 0.3.0 #1510

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 16, 2022

Description

Port of #1508 to memory-metering branch

Atree 0.3.0 uses new versions of CBOR and CircleHash:


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Atree 0.3.0 uses new versions of CBOR and CircleHash:

- fxamacker/cbor [feature/stream-mode branch] to
  March 13 commit 12f5cb4b5eb0efcd590d323ff6a292a6d4f9e36c

- fxamacker/circlehash from 0.2.0 to 0.3.0
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/memory-metering commit 2506e30
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.33ms ±33%1.59ms ±24%+19.67%(p=0.026 n=7+7)
RuntimeResourceDictionaryValues-217.2ms ± 5%17.3ms ± 3%~(p=0.620 n=7+7)
ParseInfix-210.5µs ±10%10.1µs ± 5%~(p=0.259 n=7+7)
ParseDeploy/byte_array-231.3ms ± 5%30.7ms ± 3%~(p=0.318 n=7+7)
ParseDeploy/decode_hex-21.45ms ± 7%1.43ms ± 3%~(p=0.805 n=7+7)
ParseFungibleToken-2228µs ± 4%224µs ± 2%~(p=0.093 n=6+6)
QualifiedIdentifierCreation/One_level-23.29ns ± 3%3.26ns ± 4%~(p=0.402 n=7+7)
QualifiedIdentifierCreation/Three_levels-2165ns ± 4%164ns ± 3%~(p=0.927 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2159µs ± 4%160µs ± 1%~(p=0.755 n=7+5)
ContractInterfaceFungibleToken-248.5µs ± 4%47.9µs ± 1%~(p=0.318 n=7+7)
NewInterpreter/new_sub-interpreter-22.89µs ± 7%2.83µs ± 3%~(p=0.435 n=7+7)
InterpretRecursionFib-23.38ms ± 6%3.26ms ± 3%−3.59%(p=0.011 n=7+7)
NewInterpreter/new_interpreter-21.43µs ± 5%1.37µs ± 2%−4.52%(p=0.038 n=7+7)
ParseArray-219.4ms ± 8%18.5ms ± 2%−4.77%(p=0.038 n=7+7)
 
alloc/opdelta
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%+0.00%(p=0.033 n=6+7)
RuntimeFungibleTokenTransfer-2274kB ± 0%274kB ± 0%~(p=0.805 n=6+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(all equal)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.36kB ± 0%1.36kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=0.245 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.573 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-241.0 ± 0%41.0 ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
 

@SupunS SupunS marked this pull request as ready for review March 16, 2022 20:08
@SupunS SupunS merged commit 2e995e2 into feature/memory-metering Mar 16, 2022
@SupunS SupunS deleted the supun/bump-atree-version branch March 16, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants