Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #1509

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix lint errors #1509

merged 1 commit into from
Mar 16, 2022

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 16, 2022

There is a lint error introduced by #1505, which I didn't notice (I think CI wasn't running/ wasn't showing it).

This fixes the lint error.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #1509 (96eff82) into feature/memory-metering (d6c4694) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                     Coverage Diff                     @@
##           feature/memory-metering    #1509      +/-   ##
===========================================================
- Coverage                    75.39%   75.39%   -0.01%     
===========================================================
  Files                          292      292              
  Lines                        57426    57426              
===========================================================
- Hits                         43297    43295       -2     
- Misses                       12624    12626       +2     
  Partials                      1505     1505              
Flag Coverage Δ
unittests 75.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/interpreter.go 88.93% <100.00%> (ø)
runtime/sema/simple_type.go 92.30% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c4694...96eff82. Read the comment docs.

Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/memory-metering commit d6c4694
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-216.9ms ± 6%16.6ms ± 2%~(p=0.383 n=7+7)
RuntimeFungibleTokenTransfer-21.42ms ±27%1.44ms ±23%~(p=0.456 n=7+7)
ParseDeploy/byte_array-227.3ms ±10%26.5ms ± 3%~(p=0.234 n=7+6)
ParseDeploy/decode_hex-21.39ms ± 2%1.41ms ± 3%~(p=0.383 n=7+7)
ParseInfix-29.91µs ± 2%9.95µs ± 5%~(p=0.902 n=7+7)
ParseArray-216.8ms ± 6%16.3ms ± 6%~(p=0.259 n=7+7)
ParseFungibleToken-2221µs ± 3%219µs ± 2%~(p=0.535 n=7+7)
QualifiedIdentifierCreation/One_level-23.17ns ± 2%3.20ns ± 2%~(p=0.274 n=7+7)
QualifiedIdentifierCreation/Three_levels-2162ns ± 3%160ns ± 2%~(p=0.330 n=7+7)
ContractInterfaceFungibleToken-246.9µs ± 2%47.0µs ± 3%~(p=0.534 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2159µs ± 6%157µs ± 4%~(p=0.383 n=7+7)
NewInterpreter/new_interpreter-21.34µs ± 2%1.35µs ± 4%~(p=0.274 n=7+7)
NewInterpreter/new_sub-interpreter-22.70µs ± 2%2.74µs ± 3%~(p=0.165 n=7+7)
InterpretRecursionFib-23.19ms ± 7%3.20ms ± 4%~(p=0.620 n=7+7)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.831 n=7+7)
RuntimeFungibleTokenTransfer-2274kB ± 0%274kB ± 0%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.36kB ± 0%1.36kB ± 0%~(all equal)
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%~(p=0.538 n=6+7)
 
allocs/opdelta
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.740 n=7+7)
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-241.0 ± 0%41.0 ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
 

@SupunS SupunS merged commit a6907a9 into feature/memory-metering Mar 16, 2022
@SupunS SupunS deleted the supun/memory-metering branch March 16, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants