-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewards for bridge validators and Ethereum Classic support #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store validators as a linked-list - Store reward address as a map [validator] -> rewardAddr
…rly-traverse-validators-reward-accounts-tests Update contracts to properly traverse validators reward accounts tests
ghost
added
the
in progress
label
May 2, 2019
# Conflicts: # contracts/upgradeable_contracts/BasicHomeBridge.sol # contracts/upgradeable_contracts/erc20_to_erc20/ForeignBridgeErcToErc.sol # contracts/upgradeable_contracts/erc20_to_erc20/HomeBridgeErcToErc.sol # contracts/upgradeable_contracts/native_to_erc20/ForeignBridgeNativeToErc.sol # deploy/.env.example # deploy/src/erc_to_erc/foreign.js # deploy/src/loadEnv.js
ghost
removed
the
in progress
label
May 3, 2019
…lidators' into 119-Epic-rewards-for-bridge-validators
…idators flattening sources of the new set of contracts
ghost
added
the
in progress
label
May 3, 2019
…ions Support multiple evm versions
akolotov
changed the title
Rewards for bridge validators for 'erc20-to-native' bridge mode
rewards for bridge validators and Ethereum Classic support
May 21, 2019
This PR should be reviewed as soon as #184 is merged |
…idators Flattening of contracts related to the bridge on Ethereum Classic
patitonar
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge contains all functionality related to introduction of the Fee Manager intended to take care of the reward appearing after gathering of the bridging fee from the user's transaction: #130, #132, #134, #135, #141, #142, #144, #150, #151, #167, #171, #169, #176, #166, #155, #164, #179.
Examples of Fee Managers were implemented for the following bridge modes:
native-to-erc20
:native_to_erc20/FeeManagerNativeToErc.sol
). This Fee Manager is used for the ETC-WETC bridge.native_to_erc20/FeeManagerNativeToErcBothDirections.sol
). Planned to be used for the POA-POA20 bridge.erc20-to-erc20
: fees from transfers in both directions are collected on the Home chain only and distributed by the BlockReward contract (erc20_to_erc20/FeeManagerErcToErcPOSDAO.sol
). Planned to be used for a staking token on a new POSDAO chain.erc20-to-native
:erc20_to_native/FeeManagerErcToNative.sol
). Planned to be used on the MakerDAO-xDAI bridge./erc20_to_native/FeeManagerErcToNativePOSDAO.sol
). Planned to be used for the chain coin on a new POSDAO chain.It also contains special contracts versions intended to work on the
spuriousDragon
version of EVM (Ethereum Classic): #156, #181, #184