Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-TO-NATIVE gas consumption docs #135

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Update ERC-TO-NATIVE gas consumption docs #135

merged 4 commits into from
Jan 22, 2019

Conversation

patitonar
Copy link
Contributor

Updated gas consumption for ERC-TO-NATIVE bridge with and without reward contracts. Also refactored gas consumption document to have one file per bridge mode.

@patitonar patitonar requested a review from akolotov January 17, 2019 16:03
@ghost ghost assigned patitonar Jan 17, 2019
akolotov
akolotov reviewed Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment

akolotov
akolotov approved these changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So please update the documents as soon as you address the comments in #134 and we will merge this PR.

@ghost ghost added the in progress label Jan 22, 2019
@patitonar
Copy link
Contributor Author

@akolotov Updated the documents with last changes from #134 here 74743cb

@akolotov akolotov merged commit ef6c47d into 119-Epic-rewards-for-bridge-validators Jan 22, 2019
@ghost ghost removed the in progress label Jan 22, 2019
@akolotov akolotov removed the review label Jan 22, 2019
@akolotov akolotov mentioned this pull request May 21, 2019
Merged
@akolotov akolotov deleted the update-gas-consumption-erc-to-native branch May 21, 2019 23:20
@akolotov akolotov mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patitonar @akolotov