Support transaction null status on deploy script #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
patitonar
changed the title
akolotov
requested changes
Apr 23, 2019
…ll-status-deploy-script # Conflicts: # deploy/package-lock.json # deploy/package.json # deploy/src/erc_to_erc/home.js # deploy/src/native_to_erc/foreign.js
akolotov
requested changes
May 1, 2019
akolotov
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes #155 as base to include those changes on the deployment script. So it should be merged after that PR.
For every contract deployment if
statusis not success it will also check fortx.contractAddressin casestatusis not present.https://github.com/poanetwork/poa-bridge-contracts/blob/b419821b4b38580d5a090ed4bda1867f9b62dc80/deploy/src/deploymentUtils.js#L50-L52
For transactions that changes the state if
statusis not present it will check if the state was changed. Most of these checks can be found ondeploymentUtils.jsFor example when
upgradeTois called:https://github.com/poanetwork/poa-bridge-contracts/blob/b419821b4b38580d5a090ed4bda1867f9b62dc80/deploy/src/deploymentUtils.js#L159-L163
Also a retry functionality was implemented for when we check the new state so it can avoid any race conditions. If after all retries, state didn't change, it will fail and stop the script. It uses default configuration for retry that detailed here