Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Organization Facility Search Value not clearing on tab switch #10081

Conversation

AdityaJ2305
Copy link
Contributor

@AdityaJ2305 AdityaJ2305 commented Jan 21, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Refactor
    • Updated caching strategy for facility data filtering mechanism
    • Adjusted cache parameter to optimize data retrieval performance

@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner January 21, 2025 08:32
Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

Walkthrough

The pull request involves a modification to the useFilters hook in the OrganizationFacilities.tsx file. The change specifically alters the cacheBlacklist parameter from ["facility"] to ["name"]. This adjustment suggests a refinement in the caching strategy for facility-related data, potentially addressing how cached information is managed and retrieved within the component.

Changes

File Change Summary
src/pages/Organization/OrganizationFacilities.tsx Modified cacheBlacklist parameter in useFilters hook from ["facility"] to ["name"]

Assessment against linked issues

Objective Addressed Explanation
Facility data update after editing [#10073] Unclear if this change directly resolves the automatic data update issue

Possibly related PRs

Suggested labels

needs review, changes required

Suggested reviewers

  • Jacobjeevan
  • rithviknishad

Poem

🐰 A rabbit's cache, once set in stone,
Now shifts its gaze to names unknown
With whiskers twitching, data's might
Transforms the cache with pure delight!
A subtle change, a coding dance 🕺


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 46faa4b and f7611cc.

📒 Files selected for processing (1)
  • src/pages/Organization/OrganizationFacilities.tsx (1 hunks)
🔇 Additional comments (1)
src/pages/Organization/OrganizationFacilities.tsx (1)

35-35: LGTM! The change addresses the search value persistence issue.

The modification to use cacheBlacklist: ["name"] will prevent the search value from being cached, ensuring it clears when switching tabs.

Let's verify the fix works as expected:

✅ Verification successful

The change is consistent with codebase patterns and correctly implements search value clearing.

The modification aligns with how search fields are handled across other components, where search-related parameters are consistently blacklisted to prevent caching. This implementation matches similar patterns seen in OrganizationPatients, EncounterList, and other components that handle search functionality.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any other instances where facility search might be cached
# to ensure consistent behavior across the application

# Look for other useFilters usage with name parameter
ast-grep --pattern 'useFilters({ $$$, cacheBlacklist: [$$$] $$$})'

# Look for related name search implementations
rg -A 3 'name: qParams.name'

Length of output: 2331


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1f85d8c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/678fa6a6d8769e00086e718b
😎 Deploy Preview https://deploy-preview-10081--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad merged commit 6a26ae0 into ohcnetwork:develop Jan 22, 2025
16 checks passed
Copy link

@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@coderabbitai coderabbitai bot mentioned this pull request Jan 22, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search input value in Organization Facility tab not clearing on tab switch
2 participants