GovtOrganization Selector #10090
GovtOrganization Selector #10090
Conversation
WalkthroughThe pull request introduces a new custom hook Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/pages/Organization/components/GovtOrganizationSelector.tsx (1)
63-68: Improve Readability by Refactoring Nested Ternary OperatorsThe nested ternary operators used here reduce code readability and can make the code harder to maintain. Consider refactoring this logic using a helper function or if-else statements to enhance clarity.
Apply this diff to refactor the label rendering:
-{t( - currentLevel - ? `SYSTEM__govt_org_type__${currentLevel.metadata?.govt_org_type}` - : index === 0 - ? "SYSTEM__govt_org_type__default" - : `SYSTEM__govt_org_type__${previousLevel?.metadata?.govt_org_children_type || "default"}`, -)} +{ + const labelKey = currentLevel + ? `SYSTEM__govt_org_type__${currentLevel.metadata?.govt_org_type}` + : index === 0 + ? "SYSTEM__govt_org_type__default" + : `SYSTEM__govt_org_type__${previousLevel?.metadata?.govt_org_children_type || "default"}`; + t(labelKey); +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/hooks/useGovtOrganizationLevel.ts(1 hunks)src/pages/Organization/components/GovtOrganizationSelector.tsx(2 hunks)
🔇 Additional comments (2)
src/pages/Organization/components/GovtOrganizationSelector.tsx (1)
136-142: Calculation oftotalLevelsis CorrectThe logic for calculating
totalLevelsaccurately determines the number of organization levels to display based on the selected levels and whether the last selected organization has children.src/hooks/useGovtOrganizationLevel.ts (1)
66-71: Handle UndefinedorganizationsSafelyWhile mapping
organizations?.resultsto options, ensure thatorganizationsis defined to prevent potential runtime errors. The current implementation uses the optional chaining operator and defaults to an empty array, which is appropriate.
|
PR looks good to me, need to fix the cypress |
nihal467
added
tested
Cypress Test Pending
|
@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
|
Let's fix the cypress issue in a separate PR. |
|
when you type to try aluva in the local body dropdown, its goes into loading state in between, seem like a state management issue, can you look into it |
I had added a spinner, funnily missed testing the search portion after adding the spinner 😅 . Anyways, adjusted to display spinner alongside the dropdown, rather than instead of. |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Improvements