Fixed Per Page card limit in Encounter list, organisation (Facility, Patients ) #9963

nihal467 · 2025-01-14T14:06:12Z

Proposed Changes

Fixes #issue_number
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Improvements
- Increased pagination limit from 14 to 15 in multiple components:
  - Encounters list
  - Organization facilities
  - Organization patients

This change allows for displaying one additional item per page across different sections of the application.

coderabbitai · 2025-01-14T14:06:21Z

Walkthrough

This pull request involves a consistent modification across multiple components, specifically adjusting the limit parameter in the useFilters hook from 14 to 15. The changes are applied in three files: EncounterList.tsx, OrganizationFacilities.tsx, and OrganizationPatients.tsx. This uniform change suggests a deliberate update to increase the number of items retrieved or displayed per page across different sections of the application.

Changes

File	Change Summary
`src/pages/Encounters/EncounterList.tsx`	Updated `useFilters` hook limit from 14 to 15
`src/pages/Organization/OrganizationFacilities.tsx`	Updated `useFilters` hook limit from 14 to 15
`src/pages/Organization/OrganizationPatients.tsx`	Updated `useFilters` hook limit from 14 to 15

Possibly related PRs

Conditionaly renders pagination component if number of entries is more than results per page #9004: Modifies useFilters hook configuration in OrganizationFacilities component
Conditionaly renders pagination component if number of entries is more than results per page #9004: Changes limit parameter in OrganizationPatients component

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 Pagination's Hop

From fourteen to fifteen we leap,
A rabbit's count, no longer too steep
More items dance across the page
With limits raised, we set the stage
A small change, but oh so bright! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-14T14:06:31Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`0c2f4e9`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67866f576275f000089a8169
😎 Deploy Preview	https://deploy-preview-9963--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-01-14T14:07:31Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`0c2f4e9`
Status:	✅ Deploy successful!
Preview URL:	https://c62e9f9a.care-fe.pages.dev
Branch Preview URL:	https://fix-patient-pagination.care-fe.pages.dev

View logs

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8d7a81 and 0c2f4e9.

📒 Files selected for processing (3)

src/pages/Encounters/EncounterList.tsx (1 hunks)
src/pages/Organization/OrganizationFacilities.tsx (1 hunks)
src/pages/Organization/OrganizationPatients.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cypress-run (1)
GitHub Check: Cloudflare Pages: care-fe

🔇 Additional comments (2)

src/pages/Organization/OrganizationFacilities.tsx (1)

34-34: LGTM! The new limit improves visual consistency.

The change from 14 to 15 items ensures complete rows in the grid layout (5 rows × 3 columns), enhancing the visual presentation of facility cards.

src/pages/Organization/OrganizationPatients.tsx (1)

32-32: LGTM! Consistent with facility list implementation.

The change maintains consistency with the facility list view, ensuring uniform pagination behavior across the organization views.

src/pages/Encounters/EncounterList.tsx

cypress · 2025-01-14T14:09:42Z

CARE Run #4306

Run Properties: Passed #4306 • 0c2f4e9336: Fixed Per Page card limit in Encounter list, organisation (Facility, Patients )

Project	`CARE`
Branch Review	`fix-patient-pagination`
Run status	`Passed #4306`
Run duration	`01m 48s`
Commit	`0c2f4e9336: Fixed Per Page card limit in Encounter list, organisation (Facility, Patients )`
Committer	`Mohammed Nihal`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

github-actions · 2025-01-14T14:25:02Z

@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

fix pagination per page limit

0c2f4e9

nihal467 requested a review from a team as a code owner January 14, 2025 14:06

nihal467 mentioned this pull request Jan 14, 2025

Cumulative Issues in Develop Branch #9945

Closed

12 tasks

coderabbitai bot reviewed Jan 14, 2025

View reviewed changes

src/pages/Encounters/EncounterList.tsx Show resolved Hide resolved

rithviknishad approved these changes Jan 14, 2025

View reviewed changes

rithviknishad merged commit 111ebf5 into develop Jan 14, 2025
30 checks passed

rithviknishad deleted the fix-patient-pagination branch January 14, 2025 14:24

nihal467 added this to the Palliative Care Release milestone Jan 14, 2025

This was referenced Jan 14, 2025

Add pagination and search to OrganizationUsers #9967

Merged

Fix : Filter badges visibility in resource page on selecting same date #10002

Merged

Fix: Organization Facility Search Value not clearing on tab switch #10081

Merged

This was referenced Feb 19, 2025

Fixes:Paginated-response #10705

Closed

Fixed Pagination in facility specific user tab #10729

Merged

coderabbitai bot mentioned this pull request Mar 1, 2025

Bug : fixed the Resposiveness of facility card(#10911) #10915

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Per Page card limit in Encounter list, organisation (Facility, Patients ) #9963

Fixed Per Page card limit in Encounter list, organisation (Facility, Patients ) #9963

nihal467 commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 14, 2025

coderabbitai bot left a comment

cypress bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

Fixed Per Page card limit in Encounter list, organisation (Facility, Patients ) #9963

Fixed Per Page card limit in Encounter list, organisation (Facility, Patients ) #9963

Conversation

nihal467 commented Jan 14, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 14, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 14, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Jan 14, 2025

Deploying care-fe with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Jan 14, 2025

CARE Run #4306

github-actions bot commented Jan 14, 2025

nihal467 commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 14, 2025 •

edited

Loading