-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace datetime and zoneinfo_compiled crates with chrono #867
Conversation
I just started using NixOS and I'm seeing |
I guess it might be #856 which is fixed by this? |
Actually I was able to fix the error just by setting the |
@dbeckwith I seem to have the same issue, though I have |
Please open an issue or comment under an existing issue so I can keep track of that properly. |
I found this PR after you linked it from my issue #1047 :) |
- Improve compatibility with other OSes, timezone are handled for us - Reduce significantly code handling and rendering time
Is this blocked on anything? I would love to see it merged - exa continues to have trouble with the time zone on several of my machines due to how the |
This PR makes it work properly on my Arch machine. Can it be merged soon? |
Same for me on Debian testing, I never had this issue before, but I often use |
@ogham can you please merge/release this one? |
Closing this, since exa is unmaintained (see #1243), and this has (finally 🎉) been merged in the active fork eza! |
After hours of pain trying to retro-engineer several libc including glibc, musl and Bionic (Android), I’ve come to the conclusion that it’s the wrong approach. But I couldn’t understand the mess that’s time and timezone handling in C, much less investigate every OS we would like exa to support.
Fortunately,
chrono
already provides us a nice Rust layer on top of all the nasty C platform-dependent code. Apart from Android, chrono also supports Windows.Fix #620
Fix #712
Fix #856
Fix #1047
Close #846
Close #857