Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unable to determine time zone" should be logged, not printed #980

Open
lefth opened this issue Nov 24, 2021 · 2 comments
Open

"Unable to determine time zone" should be logged, not printed #980

lefth opened this issue Nov 24, 2021 · 2 comments

Comments

@lefth
Copy link

lefth commented Nov 24, 2021

System:

  • v0.10.1
  • command: ls -l
  • operating system: linux, OpenWrt, a recent snapshot. An arm7 musl system.

What happens:
"Unable to determine time zone: No such file or directory (os error 2)" is printed to stdout.

What should happen:

  • This string should be logged, not shown--because time zones are an optional feature. The tool should still work with UTC.
  • If the string is printed, it should go to stderr, so it won't become part of output redirection. After all, the error message is not a file. It shouldn't be considered part of the data displayed by exa.
lefth added a commit to lefth/exa that referenced this issue Nov 24, 2021
lefth added a commit to lefth/exa that referenced this issue Nov 24, 2021
@ariasuni
Copy link
Collaborator

ariasuni commented Dec 5, 2021

I’m wondering, could you try the changes in this PR and tell if they fix your issue?
#867

@lefth
Copy link
Author

lefth commented Dec 6, 2021

No, I had to install time zone info and reboot. But thank you. And my point in filling this bug is that I don't expect to see error messages in every result on systems that don't have time zone into installed. ls doesn't do that, and other programs don't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants