Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes dbc.RadioButton bug #214

Merged
merged 12 commits into from
May 6, 2022
Merged

fixes dbc.RadioButton bug #214

merged 12 commits into from
May 6, 2022

Conversation

oegedijk
Copy link
Owner

tests should pass now.

@oegedijk oegedijk mentioned this pull request Apr 29, 2022
@oegedijk
Copy link
Owner Author

oegedijk commented May 4, 2022

@achimgaedke
it mostly seems to work, only some of the dropdown menu's are now misaligned it seemed, and I think they are also a bit bigger than before (prefer them to be a bit slimmer design wise). Same with the log x/log y buttons on the regression plots.

Will have a look at that.

The to_html.py static downloads still work because they still rely on bootstrap4 :) If you have time to also convert those, that would be great. Could also make it a seperate PR.

@oegedijk
Copy link
Owner Author

oegedijk commented May 6, 2022

alright, let's merge this bad boy!

the to_html conversion we will handle in #217

Thanks ever so much! This was a daunting amount of work that I had put off for the time being :)

@oegedijk oegedijk merged commit b90d4ff into master May 6, 2022
@oegedijk oegedijk deleted the bootstrap-5 branch May 6, 2022 08:20
@oegedijk oegedijk restored the bootstrap-5 branch May 6, 2022 08:21
@achimgaedke
Copy link
Contributor

Excellent!

I will spend an hour or so today ironing out some bugs, maybe we should use an issue where we collect some screenshots about styling/alignment issues.

Thanks for sharing such an awesome project in the first place.

@oegedijk
Copy link
Owner Author

oegedijk commented May 6, 2022

yeah, one of the styling issues is that I use dcc.Dropdown for the index selector dropdowns because it has the built-in search function, but dbc.Select for basically all other dropdowns, and they are styled differently. Not sure how much can be done about it, but presumably at least we could get the sizes the line up.

(not sure, not a webdev :)

@achimgaedke
Copy link
Contributor

achimgaedke commented May 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants