adjust to_html to bootstrap 5 #217
Conversation
| """ | ||
|
|
||
|
|
||
| def card_deck(*cards)->str: |
There was a problem hiding this comment.
this is no longer supported in bootstrap 5 I guess, so need to do something along these lines:
(or just use a row?)
There was a problem hiding this comment.
I'll need to configure the card widths a bit more, most will need a simple width=6 or 12 to fill half or the full space.
There was a problem hiding this comment.
yeah, but idea is that this should be automatic and responsive. So you can't just hard code it at 6 or 12. Just not specifying the width of the cols should do the trick though I guess (bootstrap will divide the cols evenly).
| @@ -281,14 +219,3 @@ def input(feature:str, value, disabled:bool=False)->str: | |||
| <input id="{feature}" type="text" value="{value}" name="{feature}" {'disabled' if disabled else ''}> | |||
| </div> | |||
| """ | |||
|
|
|||
| def jumbotron(title:str, description:str)->str: | |||
There was a problem hiding this comment.
against is used by ExplainerHub static html export, so need to create a replacement...
There was a problem hiding this comment.
What is the preferred way to test the layout/s? Could you point me to a good test routine?
There was a problem hiding this comment.
euhhh, not being a webdev, I think my routine when I originally developed it was
- export to .html
- open in browser
- see if it looks good or if there are any errors.
(also need to include the static exports to the testing battery. In general working on updating the tests to pytest now, and need to extend the coverage)
|
Just pushed a new commit, there's still something wrong with the tabs. Will try again later. |
|
made a few tweaks and now the card rows seem pretty nicely spaced |
|
Give it a test run and see if you notice anything odd, otherwise I think it's ready to merge! |
|
Tried it out again and looks good to me. |
|
cool, thanks again for all the work on this! |
|
just released it as version 0.4.0 |
Hi Oege!
Regarding conversion of static HTML output to bootstrap-5:
Most of it is done, there is one problem left: The tab function needs fixing and I don't understand how it works/worked. Do you have an idea?
I have removed some functions from
to_html, as I discovered in the process that they are unused. This probably means that I actually don't need theequal_heightparameter - which stretches cards to be aligned in height.I am still a bit distracted by aio-libs/aiobotocore#934 and #901 - let's see when I come back to this.