Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to bootstrap 5 #206

Closed
wants to merge 5 commits into from
Closed

update to bootstrap 5 #206

wants to merge 5 commits into from

Conversation

achimgaedke
Copy link
Contributor

Hi Oege!

Here's a WIP pull request porting this project to bootstrap-5, it was lying around for a month...

There are two show stoppers I know of:

I also haven't actually tested the dashboard systematically, just the titanic classifier and played a little bit with the hub.

Let's see what I'm up to in the next weeks.

@oegedijk
Copy link
Owner

@achimgaedke Awesome! Thank you so much!

There were a ton of breaking changes to the new bootstrap5/dash-bootstrap-components v1, and it seems explainerdashboard used basically almost all of them :)

Will try to have a closer look the coming week.

Would be nice if dash-auth also gets upgraded soon, so we can make the whole library with all dependencies dash v2 compatible.

Thanks again! That must have been quite an effort!

@achimgaedke
Copy link
Contributor Author

just adding a conda environment file for easy testing.

name: explainer
channels:
  - conda-forge
dependencies:
  - pip
  - wheel
  - numba
  # from explainerdashboard feedstock
  - click
  - dash>=2.3.1
  # installed below
  # - dash-auth
  - dash-bootstrap-components>=1
  - dash-core-components
  - dash-html-components
  - dash-table
  - dtreeviz
  - flask_simplelogin
  - joblib
  - jupyter-dash
  - numpy
  - orjson
  - oyaml
  - pandas
  - python
  - scikit-learn
  - shap
  - waitress
  # from dash-auth feedstock
  - chart-studio
  - dash
  - flask
  - flask-compress
  - flask-seasurf
  - itsdangerous
  - python
  - requests
  - retrying
  - ua-parser
  - pip:
    - git+https://github.com/jlondonob/dash-auth.git@dash-2
    - git+https://github.com/achimgaedke/explainerdashboard.git@bootstrap-5

@oegedijk
Copy link
Owner

tried to push some updates to this PR branch, but accidentally opened a new one: #214

@oegedijk
Copy link
Owner

looks good so far. Think we only need to update to_html.py to upgrade the static exports to bootstrap5 and if then if nothing breaks we can release.

@achimgaedke
Copy link
Contributor Author

achimgaedke commented Apr 29, 2022 via email

@achimgaedke
Copy link
Contributor Author

Ok, I've used git+https://github.com/oegedijk/explainerdashboard.git@bootstrap-5 and played a bit with it. Excellent!

Regarding to_html: Even the "Download" result for the static html export looks good.

Regarding dash-auth: For the use of conda/mamba, I could imagine it is better for now to use the main dash-auth version and add

# the official dash_auth release uses deprecated imports
warnings.filterwarnings(
    "ignore",
    # NB the \n at the beginning of the message :-/
    r"\nThe dash_\w+_components package is deprecated",
    UserWarning,
    "dash_auth.plotly_auth",
)

before the import, so this project can use the package as it comes from pypi/conda feedstock for a while.

Ready to merge? What do you think?

@oegedijk
Copy link
Owner

oegedijk commented May 6, 2022

closing this one as it has been handled by #214 instead...

thanks again!

@oegedijk oegedijk closed this May 6, 2022
@achimgaedke achimgaedke deleted the bootstrap-5 branch November 24, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants