-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to bootstrap 5 #206
Conversation
@achimgaedke Awesome! Thank you so much! There were a ton of breaking changes to the new Will try to have a closer look the coming week. Would be nice if Thanks again! That must have been quite an effort! |
just adding a conda environment file for easy testing. name: explainer
channels:
- conda-forge
dependencies:
- pip
- wheel
- numba
# from explainerdashboard feedstock
- click
- dash>=2.3.1
# installed below
# - dash-auth
- dash-bootstrap-components>=1
- dash-core-components
- dash-html-components
- dash-table
- dtreeviz
- flask_simplelogin
- joblib
- jupyter-dash
- numpy
- orjson
- oyaml
- pandas
- python
- scikit-learn
- shap
- waitress
# from dash-auth feedstock
- chart-studio
- dash
- flask
- flask-compress
- flask-seasurf
- itsdangerous
- python
- requests
- retrying
- ua-parser
- pip:
- git+https://github.com/jlondonob/dash-auth.git@dash-2
- git+https://github.com/achimgaedke/explainerdashboard.git@bootstrap-5 |
tried to push some updates to this PR branch, but accidentally opened a new one: #214 |
looks good so far. Think we only need to update |
Might do something in the next days/week, just travelled to your time zone
:-)
…On Fri, 29 Apr 2022, 12:11 Oege Dijk, ***@***.***> wrote:
looks good so far. Think we only need to update to_html.py to upgrade the
static exports to bootstrap5 and if then if nothing breaks we can release.
—
Reply to this email directly, view it on GitHub
<#206 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTGKNRBS4MXBIBLB7SSPNTVHOYURANCNFSM5TTPNGCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ok, I've used git+https://github.com/oegedijk/explainerdashboard.git@bootstrap-5 and played a bit with it. Excellent! Regarding Regarding # the official dash_auth release uses deprecated imports
warnings.filterwarnings(
"ignore",
# NB the \n at the beginning of the message :-/
r"\nThe dash_\w+_components package is deprecated",
UserWarning,
"dash_auth.plotly_auth",
) before the import, so this project can use the package as it comes from pypi/conda feedstock for a while. Ready to merge? What do you think? |
closing this one as it has been handled by #214 instead... thanks again! |
Hi Oege!
Here's a WIP pull request porting this project to bootstrap-5, it was lying around for a month...
There are two show stoppers I know of:
to_html
functions to bootstrap-5I also haven't actually tested the dashboard systematically, just the titanic classifier and played a little bit with the hub.
Let's see what I'm up to in the next weeks.