Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dash v2 #125

Closed
wants to merge 2 commits into from
Closed

Support Dash v2 #125

wants to merge 2 commits into from

Conversation

jlondonobo
Copy link

@jlondonobo jlondonobo commented Feb 26, 2022

What it does

  1. Add support for dash v2 imports (from dash import html, dcc).
  2. Fix test errors in test_api_requests.py.
  3. Set store_test_results in .circlei/config.yml to store test results for easier debugging.

How is this helpful
No more import warnings: the dash_html_components package is deprecated. Please replace import dash_html_components as html ... when using dash-auth.

Context
This PR is meant to solve #121. #122 was on the right path so I based myself in that PR.

Next steps
There are still 19 failed tests which I think are all caused by the same problem The users dict is widely used throughout test_plotly_auth_integration.py but it requires environmental variables that are never defined (I could have missed something).
image

Thus, test such as this will fail
image

@jlondonobo jlondonobo changed the title Dash 2 Support Dash v2 Feb 26, 2022
@jlondonobo jlondonobo mentioned this pull request Feb 26, 2022
@lambda-science
Copy link

Any updates on merging this branch ?

@ColinMaudry
Copy link

ColinMaudry commented Apr 26, 2022

Maybe @os185059 or @alexcjohnson can merge it?

@3tilley
Copy link

3tilley commented Jun 16, 2022

It would be great for us if this could be resolved

@Mo-Bud
Copy link

Mo-Bud commented Sep 21, 2022

Agreed it would be helpful for this to get reviewed as the warning is pretty annoying.

@alexcjohnson
Copy link
Collaborator

@jlondonobo apologies that we missed this for so long. I'm going to close it and make a new PR though, because the entire PlotlyAuth class (along with all the JS it entails) is long obsolete - a relic of an old version of our enterprise product that literally no customer is using anymore. That will dramatically simplify this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants