Making Encodedcontent public #861 #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2015 10:30
Merge pull request octokit#895 from naveensrinivasan/master
Making EncodedContent public to get the raw bytes of a file. octokit#861
|
That looks like a legit failure. We have some unit tests that check that models follow our conventions. |
|
Yea, needs to have the |
fix for making the setter private
|
Thanks fixed that!. It is failing again in the |
I restarted the build. I haven't had time to look into why that test fails sometimes. It's worrying. |
|
Looks good to me! |
haacked
added a commit
that referenced
this pull request
Sep 23, 2015
Making Encodedcontent public #861
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
EncodedContentpublic to get the raw bytes of a file. #861