Deploying new releases using octokit #905 #933

naveensrinivasan · 2015-10-09T01:43:59Z

Deploying new releases using octokit #905

Automate deploying to github using octokit
Deploy nuget package to the nuget server.

Deploying octokit using octokit octokit#905

Conflicts: deploy.cmd deploy.fsx

naveensrinivasan · 2015-10-09T01:57:43Z

IMO we should move the SourceLink , CreateOctokitPackage, CreateOctokitReactivePackage
https://github.com/octokit/octokit.net/blob/master/build.fsx#L114-181 to the new deploy.fsx and then we could sourcelink and publish the nuget package as part of deploying.

Thoughts?

haacked · 2015-10-09T04:41:00Z

IMO we should move the SourceLink , CreateOctokitPackage, CreateOctokitReactivePackage
https://github.com/octokit/octokit.net/blob/master/build.fsx#L114-181 to the new deploy.fsx and then we could sourcelink and publish the nuget package as part of deploying.

Sounds good to me.

naveensrinivasan · 2015-10-12T23:39:55Z

The default target in deploy.cmd is CreatePackages

Here is the argument list deploy.cmd

Target - CreatePackages , ReleaseToGithub
GITOWNER - The default is octokit if nothing is provided. This is used for releasing to github
GITPASSWORD - This is used for releasing to Github . I use the https://github.com/settings/tokens
NUGETKEY - The nuget key is used for deploying to nuget

I wasn't able to deploy to nuget because I don't have private nuget key to deploy octokit.

I was able to ReleaseToGithub.

Here is the run from the ReleaseToGithub

Building project with version: LocalBuild
Shortened DependencyGraph for Target ReleaseToGithub:
<== ReleaseToGithub
   <== CreatePackages
      <== SourceLink
         <== All
      <== CreateOctokitPackage
      <== CreateOctokitReactivePackage

The resulting target order is:
 - All
 - SourceLink
 - CreateOctokitPackage
 - CreateOctokitReactivePackage
 - CreatePackages
 - ReleaseToGithub
Starting Target: All
Finished Target: All
Starting Target: SourceLink (==> All)
source indexing C:\Users\nsrinivasan\Documents\GitHub\octokit.net\Octokit\bin\Re
lease\Net45\Octokit.pdb
source indexing C:\Users\nsrinivasan\Documents\GitHub\octokit.net\Octokit\bin\Re
lease\NetCore45\Octokit.pdb
source indexing C:\Users\nsrinivasan\Documents\GitHub\octokit.net\Octokit\bin\Re
lease\Portable\Octokit.pdb
source indexing C:\Users\nsrinivasan\Documents\GitHub\octokit.net\Octokit.Reacti
ve\bin\Release\Net45\Octokit.Reactive.pdb
Finished Target: SourceLink
Starting Target: CreateOctokitPackage
Deleting contents of ./packaging/octokit\lib/net45/
Deleting contents of ./packaging/octokit\lib/netcore45/
Deleting contents of ./packaging/octokit\lib/portable-net45+wp80+win+wpa81/
Creating .nuspec file at C:\Users\nsrinivasan\Documents\GitHub\octokit.net\packa
ging\octokit\octokit.0.17.0.nuspec
Created nuspec file C:\Users\nsrinivasan\Documents\GitHub\octokit.net\packaging\
octokit\octokit.0.17.0.nuspec
C:\Users\nsrinivasan\Documents\GitHub\octokit.net\tools\NuGet\nuget.exe pack -Ve
rsion 0.17.0 -OutputDirectory "C:\Users\nsrinivasan\Documents\GitHub\octokit.net
\packaging" "octokit.0.17.0.nuspec"
Deleting C:\Users\nsrinivasan\Documents\GitHub\octokit.net\packaging\octokit\oct
okit.0.17.0.nuspec
C:\Users\nsrinivasan\Documents\GitHub\octokit.net\tools\NuGet\nuget.exe push "C:
\Users\nsrinivasan\Documents\GitHub\octokit.net\packaging\Octokit.0.17.0.nupkg"
PRIVATEKEY  in WorkingDir: C:\Users\nsrinivasan\Documents\GitHub\octokit.net\pac
kaging\octokit Trials left: 5
Pushing Octokit 0.17.0 to the NuGet gallery (https://www.nuget.org)...
Failed to process request. 'The specified API key is invalid or does not have pe
rmission to access the specified package.'.
The remote server returned an error: (403) Forbidden..
C:\Users\nsrinivasan\Documents\GitHub\octokit.net\tools\NuGet\nuget.exe push "C:
\Users\nsrinivasan\Documents\GitHub\octokit.net\packaging\Octokit.0.17.0.nupkg"
PRIVATEKEY  in WorkingDir: C:\Users\nsrinivasan\Documents\GitHub\octokit.net\pac
kaging\octokit Trials left: 4
Pushing Octokit 0.17.0 to the NuGet gallery (https://www.nuget.org)...
Failed to process request. 'The specified API key is invalid or does not have pe
rmission to access the specified package.'.
The remote server returned an error: (403) Forbidden..
C:\Users\nsrinivasan\Documents\GitHub\octokit.net\tools\NuGet\nuget.exe push "C:
\Users\nsrinivasan\Documents\GitHub\octokit.net\packaging\Octokit.0.17.0.nupkg"
PRIVATEKEY  in WorkingDir: C:\Users\nsrinivasan\Documents\GitHub\octokit.net\pac
kaging\octokit Trials left: 3

naveensrinivasan · 2015-10-12T23:53:33Z

Part of deploying release's involves manually creating ReleaseNotes based on PR's merged from the previous git tag to now.

Why not automate this?

https://gist.github.com/naveensrinivasan/d267667cf7b7dd017b90

This is what I was able to produce this using octokit from v0.16.0 tag to now. This is not perfect but it would avoid manually looking for each PR.

Created build.sh @naveensrinivasan
Add .com links to PrivateRepositoryQuotaExceededException Return links in Exception #389 @elbaloo
Updated with the logo @naveensrinivasan
Fixes for FAKE Xunit warning @naveensrinivasan
add System to required framework assemblies for net45 @adamralph
Consolidate committer info @haacked
Add a bunch of XML doc comments @haacked
Disposable repositories Consistent way to create and teardown test repositories #655 @WillsB
Clarify why convention tests are failing Making Encodedcontent public #861 #907 @khellang
Making Encodedcontent public Consider making RepositoryContent.EncodedContent public #861 Consider making RepositoryContent.EncodedContent public #861 @naveensrinivasan
Updated the readme with reactive octokit. @naveensrinivasan
Changes GitHubCommit.Author/Committer GitHubCommit.Author/Committer should be a simple object, not Author type #779 @WillsB
Build fix for Xamarin Studio Solution @naveensrinivasan
Add Events URL to the Issue class. @alfhenrik
Updated test target names in the shipping releases doc @alfhenrik
Release of v0.16 - ironic ties @haacked

Would this be useful @haacked / @shiftkey ? If so then I could make it as part of this PR.

shiftkey · 2015-10-13T06:48:01Z

Part of deploying release's involves manually creating ReleaseNotes based on PR's merged from the previous git tag to now

I'd like to do this separately for a couple of reasons:

internal things unrelated to public changes are not listed in the release notes
calling out multiple contributors on a PR (look at commit authors as well as the PR owner) is also something I like to do for each release
the PR titles are often rough or incomplete, and I like to clean them up before publishing

There's a related project GitReleaseNotes which is also in this vein which I think can help here, or something similar to your script, but for now can we punt on addressing that here?

naveensrinivasan · 2015-10-13T13:58:37Z

Sounds good. 👍

shiftkey · 2015-10-16T07:27:25Z

deploy.cmd

+cls
+
+SET TARGET="CreatePackages"
+SET GITOWNER="octokit"


Should this be named GITHUBOWNER to indicate this is specific to the GitHub API (rather than the Git repository)?

And octokit is an organization, so this is just going to fail miserably with the default. Not sure what to put here, so let's leave it empty.

I can see it's also used to find the right remote (I have both my fork and the upstream octokit repos tracked as remotes, so perhaps this needs to be two variables?

shiftkey · 2015-10-16T08:04:59Z

@naveensrinivasan this is looking really great, thanks for taking the time to work through on this.

I'll have a play around with it next week, just a couple of questions about the parameters used to identify the GitHub account owner (versus the organization the repository belongs to).

shiftkey · 2015-10-16T08:10:26Z

Octokit.fsx

+let private isRunningOnMono = System.Type.GetType ("Mono.Runtime") <> null
+
+let rec private retry count asyncF =
+    // This retry logic causes an exception on Mono:


This seems to be working on Mono master - is there a specific build we should be using here to ensure this works on Mono, or is it too early to rely on this fix being present?

isRunningOnMono is used for SourceLink . Sourcelink is excluded on mono https://github.com/fsharp/FAKE/blob/master/build.fsx#L304

naveensrinivasan · 2015-12-20T21:48:00Z

@shiftkey What do you want to do this PR?

shiftkey · 2015-12-21T01:18:31Z

@naveensrinivasan I still like the idea of this, I'm just trying to figure out the best way to incorporate this into our processes - for example, AppVeyor supports publishing GitHub releases too.

adamralph · 2016-07-29T12:19:58Z

FWIW, I think it's always better to have your processes baked into source, rather than clicky clicky config on a CI server. That said, there are options for CI config in source, e.g. .travis.yml, appveyor.yml.

shiftkey · 2016-08-01T01:17:37Z

@adamralph fair enough - and packages are already created locally. I'm just trying to tackle two different things here which are tangentially related to publishing releases:

the ability to publish pre-release packages automagically - I'd love to steal what libgit2sharp has done and repurpose that here
publishing official releases without needing my environment - that's a bit tricker, but builds upon the previous step

You can see what this looks like when you drive it from config rather than the server's settings...

adamralph · 2016-08-01T12:13:56Z

The one thing I'd probably do differently to that example is to put as much as possible into something decoupled from appveyor, e.g build.fsx. IMHO config specific to a CI platform, e.g. .travis.yml, appveyor.yml should be minimal and for the heavy lifting it should call out to something which can run anywhere.

ryangribble · 2017-01-15T13:18:17Z

Im going to close this one out since it never quite got there, and we are now moving to CAKE anyway. The good news is we intend to get deployment/packaging/publishing handled in the CAKE scripts 👍

Naveen added 3 commits October 8, 2015 21:05

Bump version to 0.17.0

25715da

Eating your own dog food octokit#905

14a299a

Deploying octokit using octokit octokit#905

Merge remote-tracking branch 'origin/play-around' into play-around

cd4f951

Conflicts: deploy.cmd deploy.fsx

naveensrinivasan changed the title ~~[WIP] Deploying new releases using octokit #905~~ Deploying new releases using octokit #905 Oct 12, 2015

shiftkey reviewed Oct 16, 2015
View reviewed changes

naveensrinivasan force-pushed the play-around branch from 30987f8 to cd4f951 Compare November 9, 2015 01:06

ryangribble closed this Jan 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploying new releases using octokit #905 #933

Deploying new releases using octokit #905 #933

naveensrinivasan commented Oct 9, 2015

naveensrinivasan commented Oct 9, 2015

haacked commented Oct 9, 2015

naveensrinivasan commented Oct 12, 2015

naveensrinivasan commented Oct 12, 2015

shiftkey commented Oct 13, 2015

naveensrinivasan commented Oct 13, 2015

shiftkey Oct 16, 2015

shiftkey Oct 16, 2015

shiftkey commented Oct 16, 2015

shiftkey Oct 16, 2015

naveensrinivasan Oct 16, 2015

shiftkey Oct 16, 2015

naveensrinivasan commented Dec 20, 2015

shiftkey commented Dec 21, 2015

adamralph commented Jul 29, 2016

shiftkey commented Aug 1, 2016

adamralph commented Aug 1, 2016

ryangribble commented Jan 15, 2017

Deploying new releases using octokit #905 #933

Deploying new releases using octokit #905 #933

Conversation

naveensrinivasan commented Oct 9, 2015

naveensrinivasan commented Oct 9, 2015

haacked commented Oct 9, 2015

naveensrinivasan commented Oct 12, 2015

naveensrinivasan commented Oct 12, 2015

shiftkey commented Oct 13, 2015

naveensrinivasan commented Oct 13, 2015

shiftkey Oct 16, 2015

Choose a reason for hiding this comment

shiftkey Oct 16, 2015

Choose a reason for hiding this comment

shiftkey commented Oct 16, 2015

shiftkey Oct 16, 2015

Choose a reason for hiding this comment

naveensrinivasan Oct 16, 2015

Choose a reason for hiding this comment

shiftkey Oct 16, 2015

Choose a reason for hiding this comment

naveensrinivasan commented Dec 20, 2015

shiftkey commented Dec 21, 2015

adamralph commented Jul 29, 2016

shiftkey commented Aug 1, 2016

adamralph commented Aug 1, 2016

ryangribble commented Jan 15, 2017