-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Upload to Github releases stopped working #894 #895
Conversation
Fix for Upload to Github releases stopped working octokit#894. The ExpandUriTemplate could handle only one parameter which is the bug.
@@ -57,9 +57,11 @@ public class TheExpandUriTemplateMethod | |||
[InlineData("https://host.com/path?name=other", "https://host.com/path?name=other")] | |||
[InlineData("https://host.com/path?name=example name.txt", "https://host.com/path{?name}")] | |||
[InlineData("https://host.com/path", "https://host.com/path{?other}")] | |||
[InlineData("https://host.com/path?name=example name.txt,label=labeltext", "https://host.com/path{?name,label}")] | |||
[InlineData("https://host.com/path?name=example name.txt,label=labeltext", "https://host.com/path{?name,label,other}")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the proper expansion? Or should it be ?name=example name.txt&label=labeltext
It should have been "&" instead of "," for the URL for the issue octokit#844
Update StringExtensionsTests.cs for the URL expansion. The initial fix was incorrect.
🆒 Did you test this out? |
Yes, I checked in the test before the actual fix that was causing the CI to fail the build. |
Ok, I just wanted to make sure you actually tested the Upload to Releases with this fix. |
Yes, I tested the Upload to releases with this fix. https://github.com/naveensrinivasan/TestUpload/releases |
Thanks!!! |
Fix for Upload to Github releases stopped working #894
Very cool. Are you going to release this as a hot fix? It's blocking the whole F# ecosystem at the moment ;-) |
Merge pull request octokit#895 from naveensrinivasan/master
Yikes! I'll try and get a release out soon. |
Yes. Thanks to projectscaffold project everybody uses Octokit. ;-) Thanks again to both of you. Really appreciate this.
|
Lol. Made my day.
|
This is now live on NuGet as of version |
Fix for Upload to Github releases stopped working #894. The
ExpandUriTemplate
could handle only one parameter which is the bug.