Double quote issue labels in search API #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
- Coverage 70.79% 67.06% -3.74%
==========================================
Files 538 538
Lines 14139 14138 -1
==========================================
- Hits 10010 9481 -529
- Misses 4129 4657 +528
|
shiftkey
changed the title
|
release_notes: Search Issues endpoint to does not handles labels containing spaces correctly |
nickfloyd
added
Type: Bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2044
Hello,
I went with the easy way, double quote all labels. It will save us the check (whether the label has spaces or not) since having quotes on normal labels doesn't change anything.
I changed the test to include a test case
label 2and tested it separately on this repository.