Double quote issue labels in search API (#2084)

octokit · Feb 9, 2020 · 911dd4a · 911dd4a
1 parent 9b136b1
commit 911dd4a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Octokit.Tests/Clients/SearchClientTests.cs b/Octokit.Tests/Clients/SearchClientTests.cs
@@ -962,7 +962,7 @@ public void TestingTheLabelsQualifier()
 
                 connection.Received().Get<SearchIssuesResult>(
                     Arg.Is<Uri>(u => u.ToString() == "search/issues"),
-                    Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:bug"));
+                    Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:\"bug\""));
             }
 
             [Fact]
@@ -977,7 +977,7 @@ public void TestingTheLabelsQualifier_Multiple()
 
                 connection.Received().Get<SearchIssuesResult>(
                     Arg.Is<Uri>(u => u.ToString() == "search/issues"),
-                    Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:bug+label:feature"));
+                    Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:\"bug\"+label:\"feature\""));
             }
 
             [Fact]
@@ -1560,7 +1560,7 @@ public void TestingTheRepoAndUserAndLabelQualifier()
                 connection.Received().Get<SearchIssuesResult>(
                     Arg.Is<Uri>(u => u.ToString() == "search/issues"),
                     Arg.Is<Dictionary<string, string>>(d => d["q"] ==
-                        "something+label:bug+user:alfhenrik+repo:octokit/octokit.net"));
+                        "something+label:\"bug\"+user:alfhenrik+repo:octokit/octokit.net"));
             }
         }
 

diff --git a/Octokit.Tests/Models/SearchIssuesRequestTests.cs b/Octokit.Tests/Models/SearchIssuesRequestTests.cs
@@ -114,9 +114,9 @@ public void HandlesLabelsAttributeCorrectly()
             var request = new SearchIssuesRequest("test");
             Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("label:"));
 
-            request.Labels = new[] { "label1", "label2" };
-            Assert.Contains("label:label1", request.MergedQualifiers());
-            Assert.Contains("label:label2", request.MergedQualifiers());
+            request.Labels = new[] { "label1", "label 2" };
+            Assert.Contains("label:\"label1\"", request.MergedQualifiers());
+            Assert.Contains("label:\"label 2\"", request.MergedQualifiers());
         }
 
         [Fact]

diff --git a/Octokit/Models/Request/SearchIssuesRequest.cs b/Octokit/Models/Request/SearchIssuesRequest.cs
@@ -328,7 +328,7 @@ public override IReadOnlyList<string> MergedQualifiers()
 
             if (Labels != null)
             {
-                parameters.AddRange(Labels.Select(label => string.Format(CultureInfo.InvariantCulture, "label:{0}", label)));
+                parameters.AddRange(Labels.Select(label => string.Format(CultureInfo.InvariantCulture, "label:\"{0}\"", label)));
             }
 
             if (No.HasValue)