Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The Labels in SearchIssuesRequest is flawed #2762

Closed
1 task done
capdiem opened this issue Aug 15, 2023 · 1 comment · Fixed by #2767
Closed
1 task done

[BUG]: The Labels in SearchIssuesRequest is flawed #2762

capdiem opened this issue Aug 15, 2023 · 1 comment · Fixed by #2767
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@capdiem
Copy link
Contributor

capdiem commented Aug 15, 2023

What happened?

When there is only one label, there is no problem.
But if there are more than one, like the problem I encountered, I can't do label:Label,Label.

label:bug,resolved matches issues with the label "bug" or the label "resolved."

var request = new SearchIssuesRequest();
request.Labels = new[] { "bug,resolved" }; // error

Labels would be format to label:"bug,resolved", This means that "bug,resolved" is one label, not two. The right thing should be label:bug,resolved or label:"bug","resolved".

#2084 changed it, I can understand. But it also caused the current problem.

Versions

7.1.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@capdiem capdiem added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Aug 15, 2023
@nickfloyd nickfloyd added the Status: Up for grabs Issues that are ready to be worked on by anyone label Aug 18, 2023
@nickfloyd nickfloyd moved this from 🆕 Triage to 🔖 Ready in 🧰 Octokit Active Aug 18, 2023
@nickfloyd nickfloyd removed the Status: Triage This is being looked at and prioritized label Aug 18, 2023
@kfcampbell
Copy link
Member

Agreed that what you describe should be the correct behavior. Do you have the interest/inclination to open up a PR to fix this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants