Generate code coverage output with coverlet

[StanleyGoldman]

• Integrate a tool to generate code coverage
• Integrate codecov.io
• Added badge to readme

[StanleyGoldman]

So far I'm having issues using coverlet to generate coverage. Opened an issue with them: coverlet-coverage/coverlet#188

[ryangribble]

Hey @StanleyGoldman this is awesome! I've been wanting to get coverage stuff in place. I'm not sure about coverlet, I was planning on following what John Skeet has on https://github.com/nodatime/nodatime (using dotcover I believe)

[StanleyGoldman]

Hey @ryangribble. Yea, I've just been on a code coverage spree lately.

I got coverlet and codecov working with https://github.com/octokit/octokit.graphql.net and https://github.com/justaprogrammer/MSBuildLogOctokitChecker
I'm using OpenCover and codecov for https://github.com/github/VisualStudio

I'm just having trouble with coverlet and this project, so hopefully they can help me out.

[StanleyGoldman]

Also, wouldn't you have to get a license of dotcover for this?

[ryangribble]

Hmm I had a feeling you could get dotcover for free on open source projects

[StanleyGoldman]

That is quite possible..

[shiftkey]

That is quite possible..

Here, read: https://www.jetbrains.com/buy/opensource/

[StanleyGoldman]

Okay. Well I don't know how to feel about code coverage tools. I can't find a comparison of dotCover vs other similar tools, but I did manage to get coverlet operational thanks to help from some of their users. We can use another tool in it's place as they all support a common output format.

Now i'm struggling with codecov.io. I have it integrated but I can't seem to get their report uploader to work correctly.

[StanleyGoldman]

@ryangribble I logged some issues for remaining work, but I think this is good to merge.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@60e60ca). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1866   +/-   ##
=========================================
  Coverage          ?   70.84%           
=========================================
  Files             ?      529           
  Lines             ?    13928           
  Branches          ?        0           
=========================================
  Hits              ?     9867           
  Misses            ?     4061           
  Partials          ?        0

[tonerdo]

Just checking if you're encountering any issues with Coverlet that's preventing this from getting merged

[ryangribble]

Sadly I let this one drift and I'm struggling to get back up to speed on it 😳

Apart from the obvious merge conflicts, it seems like some other things could possibly need looking at now due to the passage of time... for example this is using a local implementation that runs coverlet.exe as a cake tool directly, whereas the linked issue indicates this may now be merged into the Cake.Coverlet library.

Im also wanting to understand the implications of changing pdb type to portable, and can spot a few things (like hardcoded paths to coverlet.exe) that should be tidied up (declare coverlet path in a more central place, etc)

[StanleyGoldman]

@ryangribble I've also been MIA on this, so it's not just you.
I'll update the PR and dependencies used.

And yea, we'll have to find out some more information regarding PDB types.

[StanleyGoldman]

Removed that pdb change. It seems I was working around an issue in coverlet and not realizing it. coverlet-coverage/coverlet#476

[shiftkey]

@StanleyGoldman great - thanks for following up with that helpful context!

[shiftkey]

release_notes: Added code coverage reporting to CI build