[WIP] Coverlet tool execution #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Romanx Take a look when you can, please feel free to push to the branch if you'd like. |
|
@StanleyGoldman Hi there. I think i've got this working but i'm unfortunately not able to push to your fork. Not sure why or how that works, not sure if you've got any idea? 😄 |
|
Hey @Romanx, that's really weird. I have this checkbox ticked.
But go ahead, close this pull request and push a new branch to your own repo with my stuff. |
|
@StanleyGoldman It's probably something i'm doing wrong. I'll open it here and open a PR and we'll continue the discussion. Thanks for your contribution up to now! |
|
Superseded by #10 |
|
Superseded by #11 you mean.. |
|
@StanleyGoldman yup indeed i do 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
At first I was just going to quickly rip what I implemented here: octokit/octokit.net#1866
But then I ended up looking at decompiled sources of some methods and noticed how Cake handles calling dotnet tools so I quickly made a stub. I could use your help to finish filling it in as I'm pretty new to cake and coverlet.
I don't have the time to finish right now, but I'm just not sure about the arguments. I guess I'm just not sure If the functionality in
CoverletAliases.ProcessArgumentswill be correct.Also I'm using Cake.Frosting, so I just need the methods implemented. I believe you might have some scripts to test that you can adapt to testing as a
dotnet tool.Todo:
dotnet toolhttps://github.com/StanleyGoldman/Cake.Coverlet/blob/8ec8e6938e9eaf749f198fdc7b52224da72d3462/src/Cake.Coverlet/CoverletTool.cs#L38-L45
Reference material
https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/DotNetCoreAliases.cs#L1043-L1057
https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/VSTest/DotNetCoreVSTester.cs
https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/VSTest/DotNetCoreVSTestSettings.cs