Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for mac/linux Travis builds #1875

Closed
StanleyGoldman opened this issue Sep 26, 2018 · 1 comment
Closed

Add code coverage for mac/linux Travis builds #1875

StanleyGoldman opened this issue Sep 26, 2018 · 1 comment
Assignees
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@StanleyGoldman
Copy link
Contributor

While developing #1866

I attempted to setup code coverage for travis but I had issues determining the path of coverlet when installed with dotnet install coverlet. I decided to reduce my scope and not include Travis CI.

Other notes

Commit where I attempted it

context.Coverlet(project, new CoverletToolSettings()
{
Configuration = context.Configuration,
Framework = "netcoreapp2.0",
Output = output
});

Builds

https://ci.appveyor.com/project/github-windows/octokit-net/build/0.33.0-PullRequest.1866+10.build.2870

https://travis-ci.org/octokit/octokit.net/jobs/426700235

========================================
CodeCoverage
========================================
Executing task: CodeCoverage
Executing Code Coverage Project Octokit.Tests...
An error occurred when executing task 'CodeCoverage'.
Error: Coverlet: Could not locate executable.
The command "./build.sh --linksources=true --verbosity=verbose" exited with 1.

https://travis-ci.org/octokit/octokit.net/jobs/426700236

@shiftkey
Copy link
Member

Closing this out as unimportant given how .NET Core is cross-platform and the differences between the OSes is so minor these days. As long as something is submitting code coverage stats I'm good.

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants