-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EventPayload models for the event types supported by GitHub API #1646
Closed
11 of 37 tasks
Labels
Status: Stale
Used by stalebot to clean house
Status: Up for grabs
Issues that are ready to be worked on by anyone
Comments
This was referenced Aug 3, 2017
I can hop on this one. @ryangribble |
Just noting that |
GMouron
added a commit
to GMouron/octokit.net
that referenced
this issue
Jan 22, 2019
GMouron
added a commit
to GMouron/octokit.net
that referenced
this issue
Jan 30, 2019
GMouron
added a commit
to GMouron/octokit.net
that referenced
this issue
Jan 31, 2019
ryangribble
pushed a commit
that referenced
this issue
Jan 31, 2019
👋 Hey Friends, this issue has been automatically marked as |
nickfloyd
added
Status: Stale
Used by stalebot to clean house
Status: Up for grabs
Issues that are ready to be worked on by anyone
and removed
Stale
labels
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Stale
Used by stalebot to clean house
Status: Up for grabs
Issues that are ready to be worked on by anyone
GitHub API has currently 37 event payloads that the Activity API can return, and only 8 of these are implemented in Octokit.net!
To support these as first class objects, Octokit needs a response model class added here for each one, and this magic switch statement updated to suit.
We should also add a new unit test and integration test for each payload (although these may fail if they are uncommon events so maybe we can change to unit tests using hardcoded json content from the github api docs).
Related to #1635 (DeleteEvent not supported) and #1645 (proposed workaround to allow unsupported event payloads to be provided as a Json string)
List of current event types
The text was updated successfully, but these errors were encountered: