Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EventPayload models for the event types supported by GitHub API #1646

Closed
11 of 37 tasks
ryangribble opened this issue Aug 3, 2017 · 3 comments
Closed
11 of 37 tasks
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@ryangribble
Copy link
Contributor

ryangribble commented Aug 3, 2017

GitHub API has currently 37 event payloads that the Activity API can return, and only 8 of these are implemented in Octokit.net!

To support these as first class objects, Octokit needs a response model class added here for each one, and this magic switch statement updated to suit.

We should also add a new unit test and integration test for each payload (although these may fail if they are uncommon events so maybe we can change to unit tests using hardcoded json content from the github api docs).

Related to #1635 (DeleteEvent not supported) and #1645 (proposed workaround to allow unsupported event payloads to be provided as a Json string)

List of current event types

  • CommitCommentEvent
  • CreateEvent
  • DeleteEvent
  • DeploymentEvent
  • DeploymentStatusEvent
  • DownloadEvent
  • FollowEvent
  • ForkEvent
  • ForkApplyEvent
  • GistEvent
  • GollumEvent
  • InstallationEvent
  • InstallationRepositoriesEvent
  • IssueCommentEvent
  • IssuesEvent
  • LabelEvent
  • MarketplacePurchaseEvent
  • MemberEvent
  • MembershipEvent
  • MilestoneEvent
  • OrganizationEvent
  • OrgBlockEvent
  • PageBuildEvent
  • ProjectCardEvent
  • ProjectColumnEvent
  • ProjectEvent
  • PublicEvent
  • PullRequestEvent
  • PullRequestReviewEvent
  • PullRequestReviewCommentEvent
  • PushEvent
  • ReleaseEvent
  • RepositoryEvent
  • StatusEvent
  • TeamEvent
  • TeamAddEvent
  • WatchEvent
@Hollywood
Copy link

Hollywood commented Aug 13, 2017

I can hop on this one. @ryangribble

@ryangribble
Copy link
Contributor Author

ryangribble commented Jan 4, 2018

Just noting that StatusEvent will be implemented in #1732 once merged

@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Stale label Jun 25, 2022
@github-actions github-actions bot closed this as completed Jul 3, 2022
@nickfloyd nickfloyd added Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone and removed Stale labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants