Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ReleaseEvent payload #2170

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Add support for ReleaseEvent payload #2170

merged 1 commit into from
Apr 11, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 5, 2020

Contributes to #1646

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #2170 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
+ Coverage   65.83%   65.84%   +0.01%     
==========================================
  Files         545      546       +1     
  Lines       14234    14237       +3     
  Branches      834      834              
==========================================
+ Hits         9371     9375       +4     
+ Misses       4706     4704       -2     
- Partials      157      158       +1
Impacted Files Coverage Δ
Octokit/Http/SimpleJsonSerializer.cs 96.00% <100.00%> (+0.04%) ⬆️
...s/Response/ActivityPayloads/ReleaseEventPayload.cs 100.00% <100.00%> (ø)
Octokit.Reactive/Helpers/ObservableExtensions.cs 90.29% <0.00%> (-2.92%) ⬇️
Octokit/Models/Response/Release.cs 15.38% <0.00%> (+7.69%) ⬆️

shiftkey
shiftkey approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @NextTurn!

@shiftkey shiftkey merged commit fd3b1c7 into octokit:master Apr 11, 2020
@nxtn nxtn deleted the release branch April 12, 2020 02:10
@shiftkey
Copy link
Member

release_notes: Added ReleaseEvent payload

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nxtn @shiftkey @nickfloyd