Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteEventPayload missing? #1635

Closed
Norbo11 opened this issue Jul 27, 2017 · 3 comments
Closed

DeleteEventPayload missing? #1635

Norbo11 opened this issue Jul 27, 2017 · 3 comments

Comments

@Norbo11
Copy link

Norbo11 commented Jul 27, 2017

Hey, I can't find a DeleteEventPayload anywhere, which means I'm unable to inspect such events using the Events API. Would it be possible to get it added? Also, do you know how I can work around this in the meantime?

@ryangribble
Copy link
Contributor

I need to review how that code works but it would be great if you could send a PR to implement the missing payload class!

in terms of a workaround you could obviously call the github API yourself or use the lower level octokit Connection Get method, but really the easiest way would be to implement the payload class and then use the nuget package from our appveyor feed, until the next official release to nuget.org

@ryangribble
Copy link
Contributor

I poked a bit more into this and have proposed a workaround that will allow any unsupported event types to be accessed as Json... please provide input on PR #1645

@ryangribble
Copy link
Contributor

I've raised #1646 to cover the fact that there are various missing event payloads, so I'll close this issue. If you feel like implementing the DeleteEvent please send a PR over! There is some guidance in #1646 about how to implement a new payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants