Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactions to issue response payload #1296

Closed
shiftkey opened this issue May 17, 2016 · 3 comments · Fixed by #1405
Closed

Add reactions to issue response payload #1296

shiftkey opened this issue May 17, 2016 · 3 comments · Fixed by #1405
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

Link: https://developer.github.com/v3/issues/#preview-period-org-issues

Before we do this, let's get #1295 resolved as that will involve much of the groundwork.

After that, here's what I think needs to be done:

  • add Reactions property to Issue response model
  • include the preview header to methods in IssueClient which return issues: application/vnd.github.squirrel-girl-preview
  • add tests to retrieve a known issue with reactions and verify it deserializes correctly
@martinscholz83
Copy link
Contributor

martinscholz83 commented Jun 11, 2016

@shiftkey, i take this issue and #1297 and #1298 if this ok. But I will wait of merge #1295 because of ReactionSummary

@shiftkey shiftkey modified the milestone: Reactions Support Jun 14, 2016
@ryangribble
Copy link
Contributor

@maddin2016 are you still planning on doing #1296 #1297 and #1298 ?

@martinscholz83
Copy link
Contributor

Oops 🙈 Of course!!! I didn't recognized that #1341 was merged. Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants