Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reactions to review comment payload #1298

Closed
shiftkey opened this issue May 17, 2016 · 0 comments · Fixed by #1405
Closed

add reactions to review comment payload #1298

shiftkey opened this issue May 17, 2016 · 0 comments · Fixed by #1405
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Milestone
Reactions Support

Comments

@shiftkey
Copy link
Member

Link: https://developer.github.com/v3/pulls/comments#preview-period-pull-comments

Before we do this, let's get #1295 resolved as that will involve much of the groundwork.

After that, here's what I think needs to be done:

  • add Reactions property to PullRequestReviewComment response model
  • include the preview header to methods in PullRequestReviewCommentsClient which return commit comments: application/vnd.github.squirrel-girl-preview
  • add tests to retrieve a known pull request comment with reactions and verify it deserializes correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
Reactions Support
Development

Successfully merging a pull request may close this issue.

Add reactions to issue, commit comment and review payload martinscholz83/octokit.net
2 participants
@nickfloyd @shiftkey