Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTokens - use wei in the library #147

Merged
merged 4 commits into from
Jul 14, 2020
Merged

DataTokens - use wei in the library #147

merged 4 commits into from
Jul 14, 2020

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Jul 13, 2020

closes #145

closes #144

related issues #59

@alexcos20 alexcos20 added the Status: InProgress Work in progress, don't merge label Jul 13, 2020
@alexcos20 alexcos20 requested a review from 0x3bfc July 13, 2020 18:16
@alexcos20 alexcos20 self-assigned this Jul 13, 2020
@alexcos20 alexcos20 removed the Status: InProgress Work in progress, don't merge label Jul 14, 2020
@alexcos20 alexcos20 marked this pull request as ready for review July 14, 2020 09:35
src/ocean/Assets.ts Outdated Show resolved Hide resolved
@alexcos20 alexcos20 requested a review from ssallam July 14, 2020 10:24
@0x3bfc 0x3bfc mentioned this pull request Jul 14, 2020
@alexcos20
Copy link
Member Author

closes #144 as well

Copy link
Contributor

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x3bfc 0x3bfc merged commit ed18f81 into develop Jul 14, 2020
@0x3bfc 0x3bfc deleted the bug/fix_dt_decimals branch July 14, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTokens - use wei in the library Incorrect data type for account in DataTokens create
3 participants