Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect data type for account in DataTokens create #144

Closed
mihaisc opened this issue Jul 13, 2020 · 1 comment · Fixed by #147
Closed

Incorrect data type for account in DataTokens create #144

mihaisc opened this issue Jul 13, 2020 · 1 comment · Fixed by #147

Comments

@mihaisc
Copy link
Contributor

mihaisc commented Jul 13, 2020

Account is actually account id and it should be string not Account in https://github.com/oceanprotocol/ocean-lib-js/blob/aaf3f1f62e356171cbe54096f10b51650d8d4c9a/src/datatokens/Datatokens.ts#L41
Tested locally and works ok with account id

UPDATE: After further testing, this should be checked for all functions in Datatokens.ts. I think that whenever account is used like { from: account } it should be string.

@0x3bfc
Copy link
Contributor

0x3bfc commented Jul 13, 2020

noted!

alexcos20 added a commit that referenced this issue Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants