Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTokens - use wei in the library #145

Closed
3 tasks done
alexcos20 opened this issue Jul 13, 2020 · 3 comments · Fixed by #147
Closed
3 tasks done

DataTokens - use wei in the library #145

alexcos20 opened this issue Jul 13, 2020 · 3 comments · Fixed by #147
Assignees
@alexcos20

Comments

@alexcos20
Copy link
Member

alexcos20 commented Jul 13, 2020 •
edited
Loading

  • - update datatokens functions to accept numbers as params, but use toWei inside
  • - update ddo cost to be specified in number(float) (ocean.assets.create), but keep it in wei
  • - have utility function in the library to do the conversion both ways
@alexcos20
Copy link
Member Author

see branch bug/fix_dt_decimals for 1st issue

@alexcos20 alexcos20 self-assigned this Jul 13, 2020
@alexcos20 alexcos20 mentioned this issue Jul 13, 2020
Merged
@alexcos20
Copy link
Member Author

@ssallam @0x3bfc
2. Does it really makes sense to keep cost in wei in ddo? all interfaces are Numbers now, so we can use floats
3. web3.utils.toWei and web3.utils.fromWei should be enough. Do we need to add other helpers in the libs?

@alexcos20
Copy link
Member Author

fixed 2 and 3 as well in #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataTokens - use wei in the library oceanprotocol/ocean.js
1 participant
@alexcos20