Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems when non-ASCII characters in folder name #459

Closed
yannl35133 opened this issue Jun 4, 2021 · 2 comments
Closed

Problems when non-ASCII characters in folder name #459

yannl35133 opened this issue Jun 4, 2021 · 2 comments

Comments

@yannl35133
Copy link

When I have the file structure ("""file contents""") :

New
├── dune-project            """(lang dune 2.4)"""
├── lib
│   ├── dune                """(library    (name lib))"""
│   └── lib.ml              """type t"""
└── lib2
    ├── dune                """(library    (name lib2)    (libraries lib))"""
    └── lib2.ml             """type t = Lib.t"""

everything works as intended, but when I change New to Néw, type Lib.t becomes unbound in lib2.ml.
When I build with Dune, it compiles fine (as there is no problem)

I have reported this issue before (in the wrong repository, here), and it was fixed before; I don't know why it reappeared.
@reubenrowe reubenrowe mentioned this issue Jul 6, 2021
Closed
@tatchi tatchi mentioned this issue Sep 1, 2021
Closed
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Jul 7, 2022
@rgrinberg
[new release] ocaml-lsp-server, lsp and jsonrpc (1.12.3)
541b3ec 
CHANGES:

## Fixes

- Fix a bad interaction between inferred interfaces and promotion code actions
  in watch mode (ocaml/ocaml-lsp#753)

- Fix URI parsing (ocaml/ocaml-lsp#739 fixes ocaml/ocaml-lsp#471 and ocaml/ocaml-lsp#459)
@rgrinberg rgrinberg mentioned this issue Jul 7, 2022
Merged
@ulugbekna
Copy link
Collaborator

Fixed by #739, AFAIU

@yannl35133
Copy link
Author

Can't reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle non ASCII characters in folder name tatchi/ocaml-lsp
2 participants
@ulugbekna @yannl35133