Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ocaml-lsp-server, lsp and jsonrpc (1.12.3) #21741

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

rgrinberg
Copy link
Member

LSP Server for OCaml

CHANGES:

Fixes

CHANGES:

## Fixes

- Fix a bad interaction between inferred interfaces and promotion code actions
  in watch mode (ocaml/ocaml-lsp#753)

- Fix URI parsing (ocaml/ocaml-lsp#739 fixes ocaml/ocaml-lsp#471 and ocaml/ocaml-lsp#459)
@mseri
Copy link
Member

mseri commented Jul 7, 2022

uri needs a lower bound:

# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlc.opt -w -40 -alert -unstable -g -bin-annot -I lsp/src/.lsp.objs/byte -I /home/opam/.opam/4.12/lib/dyn -I /home/opam/.opam/4.12/lib/jsonrpc -I /home/opam/.opam/4.12/lib/ppx_yojson_conv_lib -I /home/opam/.opam/4.12/lib/uri -I /home/opam/.opam/4.12/lib/uutf -I /home/opam/.opam/4.12/lib/yojson -intf-suffix .ml -no-alias-deps -open Lsp__ -o lsp/src/.lsp.objs/byte/lsp__Uri0.cmo -c -impl lsp/src/uri0.ml)
# File "lsp/src/uri0.ml", line 63, characters 28-67:
# 63 |   Uri.pct_encode ~component:(`Custom (`Generic, allowed_chars, "")) s
#                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: This expression has type
#          [> `Custom of [> `Generic ] * string * string ]
#        but an expression was expected of type Uri.component
#        The second variant type does not allow tag(s) `Custom
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlopt.opt -w -40 -alert -unstable -g -I lsp/src/.lsp.objs/byte -I lsp/src/.lsp.objs/native -I /home/opam/.opam/4.12/lib/dyn -I /home/opam/.opam/4.12/lib/jsonrpc -I /home/opam/.opam/4.12/lib/ppx_yojson_conv_lib -I /home/opam/.opam/4.12/lib/uri -I /home/opam/.opam/4.12/lib/uutf -I /home/opam/.opam/4.12/lib/yojson -intf-suffix .ml -no-alias-deps -open Lsp__ -o lsp/src/.lsp.objs/native/lsp__Uri0.cmx -c -impl lsp/src/uri0.ml)
# File "lsp/src/uri0.ml", line 63, characters 28-67:
# 63 |   Uri.pct_encode ~component:(`Custom (`Generic, allowed_chars, "")) s
#                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: This expression has type
#          [> `Custom of [> `Generic ] * string * string ]
#        but an expression was expected of type Uri.component
#        The second variant type does not allow tag(s) `Custom

@rgrinberg
Copy link
Member Author

Thanks for noticing. Do you mind fixing it here? I'll do it upstream

packages/lsp/lsp.1.12.3/opam Outdated Show resolved Hide resolved
@rgrinberg
Copy link
Member Author

@mseri @kit-ty-kate gentle ping

@kit-ty-kate kit-ty-kate merged commit cbd000d into ocaml:master Jul 12, 2022
@kit-ty-kate
Copy link
Member

Oops, sorry i forgot about this one. Thanks! Could you return the fixes to the opam files upstream?

@rgrinberg
Copy link
Member Author

Will do. Thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not handling spaces in parent directory name
3 participants