-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] ocaml-lsp-server, lsp and jsonrpc (1.12.3) #21741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ## Fixes - Fix a bad interaction between inferred interfaces and promotion code actions in watch mode (ocaml/ocaml-lsp#753) - Fix URI parsing (ocaml/ocaml-lsp#739 fixes ocaml/ocaml-lsp#471 and ocaml/ocaml-lsp#459)
kit-ty-kate
reviewed
Jul 7, 2022
|
Thanks for noticing. Do you mind fixing it here? I'll do it upstream |
mseri
reviewed
Jul 7, 2022
@mseri @kit-ty-kate gentle ping |
Oops, sorry i forgot about this one. Thanks! Could you return the fixes to the opam files upstream? |
Will do. Thanks for the quick response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP Server for OCaml
CHANGES:
Fixes
Fix a bad interaction between inferred interfaces and promotion code actions
in watch mode (fix(ocamllsp): infer intf for closed docs ocaml-lsp#753)
Fix URI parsing (Improve uri parsing ocaml-lsp#739 fixes Not handling spaces in parent directory name ocaml-lsp#471 and Problems when non-ASCII characters in folder name ocaml-lsp#459)