fix(ocamllsp): infer intf for closed docs #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug when inferring the interface of a module whose implementation hasn't been opened. Since the module hasn't been opened by the user, we shouldn't open in the document store and confuse the dynamic registration subscription manager. In particular, if there is a promotion pending for the document, this would wrongly remove the dynamic registration. Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 70ff54c0-ab14-4ed5-82ed-e238173c0203
tatchi
approved these changes
Jun 28, 2022
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Jul 7, 2022
CHANGES: ## Fixes - Fix a bad interaction between inferred interfaces and promotion code actions in watch mode (ocaml/ocaml-lsp#753) - Fix URI parsing (ocaml/ocaml-lsp#739 fixes ocaml/ocaml-lsp#471 and ocaml/ocaml-lsp#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug when inferring the interface of a module whose
implementation hasn't been opened.
Since the module hasn't been opened by the user, we shouldn't open in
the document store and confuse the dynamic registration subscription
manager. In particular, if there is a promotion pending for the
document, this would wrongly remove the dynamic registration.
Signed-off-by: Rudi Grinberg [email protected]
ps-id: 70ff54c0-ab14-4ed5-82ed-e238173c0203