new memory behaviour #2189
new memory behaviour #2189
Conversation
|
@volodya-lombrozo @yegor256 Please have a look at new strictly typed |
There was a problem hiding this comment.
@Graur Overall, I appreciate the idea, but I'm unclear about the rationale behind these restrictions. Would it be possible for you to provide some links or further explanation to help me understand the reasons better? Thank you.
| [e] | ||
| e > @ | ||
| nop | ||
| $.equal-to "Memory type missmatch: expected <int>, got <float>" |
There was a problem hiding this comment.
@Graur Let's imagine, that int and float have the same size - 4 bytes (like in Java). Should we check their types? Or we might compare just size?
There was a problem hiding this comment.
@volodya-lombrozo Yes, you are right. Thanks!
Moreover there is no chance to compare types if I try to implement it in EO. So we decided to avoid this change
| [e] | ||
| e > @ | ||
| nop | ||
| $.equal-to "Not enough memory to write: expected <2^63 - 1>, got <2^63>" |
There was a problem hiding this comment.
@Graur Should we throw an exception in that case? Maybe it's better just to write -9,223,372,036,854,775,808?
There was a problem hiding this comment.
@volodya-lombrozo I like it, thanks!
|
@volodya-lombrozo The main reason is to make |
|
@yegor256 Please have a look |
|
@rultor merge |
Closes: #761
PR-Codex overview
This PR focuses on ensuring that the memory can only accept one type of data primitives. It also implements error handling for overflow and strict typing for different data types.
Detailed summary