Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'memory' must be strictly typed #761

Closed
yegor256 opened this issue Jun 19, 2022 · 12 comments · Fixed by #2189
Closed

'memory' must be strictly typed #761

yegor256 opened this issue Jun 19, 2022 · 12 comments · Fixed by #2189
Assignees
Labels
Milestone

Comments

@yegor256
Copy link
Member

yegor256 commented Jun 19, 2022

Let's make sure memory can only accept one "type" of data primitives. In other words, this code should lead to an error:

memory 42 > m
m.write 3.1416

At the first line we save int and at the second one attempt to save float. The second line should cause an error.

Let's not forget to update the "Origins of Objects" paper.

p.s. Moreover, let's implement memory in EO instead of Java and let it use ram. This will mean that it will fail with "not enough memory" if we make an attempt to store a longer string into it:

memory "Hello" > m
m.write "Much longer string!"
@yegor256 yegor256 added the bug label Jun 19, 2022
@yegor256
Copy link
Member Author

@Graur can you please help

@Graur
Copy link
Contributor

Graur commented Jun 19, 2022

@yegor256 How can we check types in EO? By size?

@yegor256
Copy link
Member Author

@Graur yes, just checking by size will be enough

@Graur
Copy link
Contributor

Graur commented Aug 22, 2022

@MCJOHN974 Can you help us here?

@Graur Graur assigned Graur and MCJOHN974 and unassigned Graur Aug 22, 2022
@Graur
Copy link
Contributor

Graur commented Sep 5, 2022

@MCJOHN974 What about the progress of this task? Do you need some help?

@Graur Graur assigned Graur and unassigned MCJOHN974 Oct 4, 2022
@yegor256
Copy link
Member Author

yegor256 commented Mar 5, 2023

@Graur what's up with this?

@mximp mximp added this to the M3 milestone May 29, 2023
@Graur
Copy link
Contributor

Graur commented Jun 29, 2023

@yegor256 How do you think, do we need this changes right now? They will break a lot of our existing code. I asked because I wrote some tests and understood the consequences

@yegor256
Copy link
Member Author

@Graur really "a lot"? let's disable the tests that fail and add puzzles. This change is very important, we must introduce it.

@0pdd
Copy link

0pdd commented Jul 5, 2023

@yegor256 the puzzle #2211 is still not solved.

@0pdd
Copy link

0pdd commented Aug 24, 2023

@yegor256 3 puzzles #2211, #2434, #2435 are still not solved.

@0pdd
Copy link

0pdd commented Aug 29, 2023

@yegor256 3 puzzles #2211, #2434, #2452 are still not solved; solved: #2435.

@0pdd
Copy link

0pdd commented Oct 1, 2023

@yegor256 2 puzzles #2211, #2434 are still not solved; solved: #2435, #2452.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants