Support more than one header in External Channel #386
Conversation
| courier.ConfigSendBody: `<msg><to>{{to}}</to><text>{{text}}</text><from>{{from}}</from><quick_replies>{{quick_replies}}</quick_replies></msg>`, | ||
| courier.ConfigContentType: contentXML, | ||
| courier.ConfigSendMethod: http.MethodPost, | ||
| courier.ConfigSendAuthorization: "Token ABCDEF", |
There was a problem hiding this comment.
should make sure one of these tests is still using the old send_authorization key
There was a problem hiding this comment.
@jcbalmeida can you just make sure one of these is using the old config key and then we'll get this merged
There was a problem hiding this comment.
Yes, we made a data migration in RapidPro to keep it compatible to existing channels: https://github.com/Ilhasoft/rapidpro/blob/f75d9a4d81c7af41d6ea7929f3b0674e4666145f/temba/channels/migrations/0136_external_headers.py#L6-L18
The PR for RapidPro is nyaruka/rapidpro#3589
There was a problem hiding this comment.
I mean tweak one of these tests so we know it still works with the old config, until that migration is run
There was a problem hiding this comment.
I pushed a commit just now with this tweak to ensure compatibility
|
looks fine tho we're in code freeze for next 2 weeks |
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 71.42% 71.37% -0.06%
==========================================
Files 94 93 -1
Lines 8276 8258 -18
==========================================
- Hits 5911 5894 -17
Misses 1762 1762
+ Partials 603 602 -1
Continue to review full report at Codecov.
|
Solves the issue https://github.com/rapidpro/rapidpro/issues/1547
Obs.: It needs nyaruka/rapidpro#3589 to work