Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor external channel handler to use headers config on send #81

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

rasoro
Copy link
Member

@rasoro rasoro commented Nov 9, 2021

related to nyaruka#386

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #81 (464d64d) into main (8d70f22) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files          95       95           
  Lines        8444     8444           
=======================================
  Hits         6039     6039           
  Misses       1788     1788           
  Partials      617      617           
Impacted Files Coverage Δ
channel.go 27.27% <ø> (ø)
handlers/external/external.go 91.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d70f22...464d64d. Read the comment docs.

@rasoro rasoro merged commit 258b740 into main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants