-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more than one header in External Channel #3589
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3589 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 445 446 +1
Lines 25881 25885 +4
=========================================
+ Hits 25881 25885 +4
Continue to review full report at Codecov.
|
Hi @rowanseymour , any news on this and the courier PR? Thanks |
@matmsa27 just want small tweak re nyaruka/courier#386 (review) as we'll be deploying the courier side before we deploy this RP bit |
Nice, thanks @rowanseymour , I saw here that courier was merged. Please, any adjust here that you want on this PR, we will be available to fix ASAP. |
from django.db import migrations | ||
|
||
|
||
def foward(apps, schema_editor): # pragma: no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so our general rules for data migrations are..
- Just print a summary at the end like
123 channels updated, 5 ignored
- Write a unit test using
MigrationTest
(e.g. seeLine 2847 in ecc9bc2
class ScheduledBroadcastCleanupTest(MigrationTest): - Don't worry about reverse-ability
f75d9a4
to
ff889a1
Compare
Without activity, this PR will be closed in 14 days. |
This PR was closed for inactivity. |
Solves the issue https://github.com/rapidpro/rapidpro/issues/1547
Obs.: It need nyaruka/courier#386 to work