Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than one header in External Channel #3589

Closed

Conversation

jcbalmeida
Copy link

@jcbalmeida jcbalmeida commented Nov 2, 2021

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #3589 (ff889a1) into main (88b9602) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ff889a1 differs from pull request most recent head 6a417b5. Consider uploading reports for the commit 6a417b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          445       446    +1     
  Lines        25881     25885    +4     
=========================================
+ Hits         25881     25885    +4     
Impacted Files Coverage Δ
temba/channels/migrations/0136_external_headers.py 100.00% <100.00%> (ø)
temba/channels/types/external/type.py 100.00% <100.00%> (ø)
temba/channels/types/external/views.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b9602...6a417b5. Read the comment docs.

@matmsa27
Copy link

Hi @rowanseymour , any news on this and the courier PR? Thanks

@rowanseymour
Copy link
Member

@matmsa27 just want small tweak re nyaruka/courier#386 (review) as we'll be deploying the courier side before we deploy this RP bit

@matmsa27
Copy link

Nice, thanks @rowanseymour , I saw here that courier was merged. Please, any adjust here that you want on this PR, we will be available to fix ASAP.

from django.db import migrations


def foward(apps, schema_editor): # pragma: no cover
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so our general rules for data migrations are..

  1. Just print a summary at the end like 123 channels updated, 5 ignored
  2. Write a unit test using MigrationTest (e.g. see
    class ScheduledBroadcastCleanupTest(MigrationTest):
    )
  3. Don't worry about reverse-ability

@jcbalmeida jcbalmeida force-pushed the external-channel-headers-config branch from f75d9a4 to ff889a1 Compare November 23, 2021 19:51
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Without activity, this PR will be closed in 14 days.

@github-actions
Copy link

This PR was closed for inactivity.

@github-actions github-actions bot closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants