chore: remove redundant comment #1307

nhld · 2025-01-13T09:36:35Z

This is a duplicate comment as it's already mentioned in the mason part.

BALAJI24092001

For anyone who's starting Neovim with Kickstart might consider this comment useful. I didn't understand when I started, and this helped me.

nhld · 2025-01-15T03:03:26Z

@BALAJI24092001

The recent PR #1298 added a note with the same concept, as the mason config is now using opts = {} - this is now the first occurrence of using opts with an empty table in init.lua. So the fidget's note seems kinda redundant no?

kickstart.nvim/init.lua

Lines 459 to 469 in db4867a

    
           -- Automatically install LSPs and related tools to stdpath for Neovim 
        
           -- Mason must be loaded before its dependents so we need to set it up here. 
        
           -- NOTE: `opts = {}` is the same as calling `require('mason').setup({})` 
        
           { 'williamboman/mason.nvim', opts = {} }, 
        
           'williamboman/mason-lspconfig.nvim', 
        
           'WhoIsSethDaniel/mason-tool-installer.nvim', 
        
           -- Useful status updates for LSP. 
        
           -- NOTE: `opts = {}` is the same as calling `require('fidget').setup({})` 
        
           { 'j-hui/fidget.nvim', opts = {} },

Signed-off-by: Dejan Ribič <[email protected]>

@VlaDexa

* fix: prevent mason setup from being run twice (nvim-lua#1298) * fix: prevent mason setup from being run twice Addresses nvim-lua#1297 Currently, we're calling `require('mason').setup(...)` twice: * once when setting it as a dependency of `nvim-lspconfig` (since we set `config = true`) * once in the `config` function we define for `nvim-lspconfig` Calling setup twice can cause issues with, e.g., setting the `PATH` option: you might append Mason's bin dir in one setup call and prepend it in the other. We've kept the setup of `mason` in the `nvim-lspconfig` dependencies table since leaving it to the `config` function caused some plugin-loading-order related issues in the past. See: * nvim-lua#210 * nvim-lua#554 * nvim-lua#555 * nvim-lua#865 * docs: tweak comments per review feedback * chore: remove redundant comment (nvim-lua#1307) * chore: fix typo in bug report issue template (nvim-lua#1306) * Use luals 3rd library for luv (nvim-lua#1303) * Modifies the treesitter config to make it work on my computers. * Disables the focus movement keymaps. Signed-off-by: AMaugas <[email protected]> * Adds my prefences for the options. Signed-off-by: AMaugas <[email protected]> * Configures Telescope layout to my liking Signed-off-by: AMaugas <[email protected]> * Adds additional custom configuration Signed-off-by: AMaugas <[email protected]> * Enables custom plugins sourcing and changes the colorscheme plugin Signed-off-by: AMaugas <[email protected]> * Adds highlight commands for diagnostics Signed-off-by: AMaugas <[email protected]> * Updates DelphiLsp to use current buffer path. Signed-off-by: AMaugas <[email protected]> * Adds linebreak config * Tries to not lauch DelphiLsp when not on Windows * Deactivates neo-tree plugin. Signed-off-by: Bibours <[email protected]> * Adds vim-fugitive plugin. Signed-off-by: Bibours <[email protected]> * Adds buffer as source completion. Signed-off-by: Bibours <[email protected]> * Adds lazygit front end plugin. * Corrects the OS detection for delphi LSP. Signed-off-by: AMaugas <[email protected]> * Minor modifications to personal options. Signed-off-by: AMaugas <[email protected]> * Upstream update (#3) * which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) * fix: update lazy uninstall information link (nvim-lua#1148) * Disable linting autocmd for readonly buffers (nvim-lua#1202) * Disable linting autocmd for readonly buffers This should avoid linting in buffers outside of the user's control, having in mind especially the handy LSP pop-ups that describe your hovered symbol using markdown. Co-authored-by: Robin Gruyters <[email protected]> * Justify guarding try_lint in readonly buffers Co-authored-by: Robin Gruyters <[email protected]> --------- Co-authored-by: Robin Gruyters <[email protected]> * samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) * samarth-nagar fix: lazy help tag on line 931 found in issue nvim-lua#1152 * fixed white space --------- Co-authored-by: sam <[email protected]> * Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) * feat: Change diagnostic symbols if vim.g.have_nerd_font is true * feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Set breakpoint icons and their highlight colors (nvim-lua#1194) * feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Remove two because there are more than two. (nvim-lua#1213) * feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) * Fix nvim-dap not lazy loading (nvim-lua#1216) * Fix nvim-dap not lazy loading The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading. Fixed this by changing keys to a table and substituting the local variables with a lamba function * Make debug keybind descriptions more consistent * fix: which-key comment typo (nvim-lua#1227) --------- Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]> Co-authored-by: mogz <[email protected]> --------- Signed-off-by: AMaugas <[email protected]> Signed-off-by: Bibours <[email protected]> Co-authored-by: Tomas Gareau <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Nhan Luu <[email protected]> Co-authored-by: Diorman Colmenares <[email protected]> Co-authored-by: AMaugas <[email protected]> Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]> Co-authored-by: mogz <[email protected]>

* master-rebased-kick: (58 commits) Adicao annotaions README.md no copy to system (unnamedplus) and plugins adding catppuccin Use luals 3rd library for luv (nvim-lua#1303) chore: fix typo in bug report issue template (nvim-lua#1306) chore: remove redundant comment (nvim-lua#1307) fix: prevent mason setup from being run twice (nvim-lua#1298) Fix which-key delay settings (nvim-lua#1276) chore: add pre-issue requirements (nvim-lua#1288) Fix README.md grammar and typos (nvim-lua#1291) fix(gitsigns): make visual mode descriptions consistent with normal mode (nvim-lua#1266) Issue 1249 which key comments (nvim-lua#1263) Use consistent syntax style for { ... } "pseudocode" (nvim-lua#1247) Tweak outdated comment about lazy's `config` key usage. (nvim-lua#1250) fix: which-key comment typo (nvim-lua#1227) Fix nvim-dap not lazy loading (nvim-lua#1216) feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) Remove two because there are more than two. (nvim-lua#1213) Set breakpoint icons and their highlight colors (nvim-lua#1194) Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) ...

* master: Use luals 3rd library for luv (nvim-lua#1303) chore: fix typo in bug report issue template (nvim-lua#1306) chore: remove redundant comment (nvim-lua#1307)

This is a duplicate comment as it's already mentioned in the mason part. See: nvim-lua/kickstart.nvim#1307 Co-authored-by: Nhan Luu <[email protected]>

@VlaDexa

* Change statusline location to LINE:COLUMN (nvim-lua#689) * chore: remove trailing spaces from readme (nvim-lua#679) * chore: link new installation youtube video (nvim-lua#678) * Add more detail to colorscheme comment (nvim-lua#713) * Make the Nerd Font an optional requirement (nvim-lua#716) * Fix typos and whatnot (nvim-lua#731) * use init for colorscheme (nvim-lua#715) * README.md: update neo-tree example - remove legacy setting (nvim-lua#744) * feat: allow treesitter defaults to be overwritten from custom directory (nvim-lua#732) * chore: rename <C-T> to <C-t> for consistency (nvim-lua#719) * Added folke/neodev.nvim for proper nvim api completion and annotation (nvim-lua#754) Fixes nvim-lua#692 `neodev` configures Lua LSP for your Neovim config, runtime and plugins used for completion, annotations and signatures of Neovim apis With neodev, there's no more need to manually set lua_ls workspace settings which don't seem to work properly anyway as currently nvim api completion does not work. * Use `cmp-nvim-lua` as `nvim-cmp` source for neovim Lua API (nvim-lua#696) * Use cmp-nvim-lua as nvim-cmp source for neovim Lua API * Move the dependency to a more suitable place * Revert "Use `cmp-nvim-lua` as `nvim-cmp` source for neovim Lua API (nvim-lua#696)" (nvim-lua#755) This reverts commit d8a1dbc. * doc: add info about timeoutlen (nvim-lua#691) Add separate comment for `timeoutlen` option `timeoutlen` option was under unrelated comment with `updatetime` option. * Add <C-b>/<C-f> cmp mapping to scroll cmp docs (nvim-lua#750) * Move friendly snippets to dependencies of LuaSnip (nvim-lua#759) Co-authored-by: TJ DeVries <[email protected]> * doc: add note about advanced luasnip features * fix: disable ts indenting for Ruby Tree-sitter indenting for ruby is pretty terrible. But the fix requires a few steps, so showed those and documented how you could do that for other languages as well (with the tricky part being the additional_vim_regex_highlighting trick) * Update README.md (nvim-lua#763) Added file text to code block for consistency since the other plugin had file also inside code block. * conform: disable autoformat on save for specified filetypes (nvim-lua#694) Provide a method to disable autoformat on save lsp fallback for specified filetypes. By default disable for C/C++ as an example, because it does not have a well standardized coding style. Based on conform recipe: https://github.com/stevearc/conform.nvim/blob/master/doc/recipes.md * README: additional install recipes for various OS (nvim-lua#767) * assign table to filetype in lua_ls config comment (nvim-lua#770) * feat: add linter plugin (nvim-lua#699) * Some suggestions and capitalised a few words (nvim-lua#771) * Add nvim-nio as dependency for nvim-dap-ui (nvim-lua#774) It's a dependency now * Update README.md (nvim-lua#781) The recommended step of forking the repo coming sequentially after the step instructing users to clone the current repo doesn't make sense. This commit orders the install instructions in a manner that's more logical. * README: wrap long lines (nvim-lua#784) * fix nvim-lua#799 (nvim-lua#800) Add `'luadoc'`, to the `ensure_installed` of `nvim-treesitter/nvim-treesitter` * Add instructions to quit :lazy. Fixes nvim-lua#761 * Add a keymap space-f to format buffer using conform (nvim-lua#817) This works also for visual range selection Copied from conform recipe: https://github.com/stevearc/conform.nvim/blob/master/doc/recipes.md * Don't lazy load conform plugin (nvim-lua#818) * README: move backup and paths from external deps to install section (nvim-lua#819) * Add a pull request template (nvim-lua#825) * Update README (nvim-lua#832) * Arch, btw (nvim-lua#852) * Arch, btw * Add unzip * Add unzip for Fedora and --needed arg for Arch * Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854) * Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856) * Enable inlay hints for the supporting servers (nvim-lua#843) * Move plugin examples from README to optional plugin files (nvim-lua#831) * Move autopairs example from README to an optional plugin * Move neo-tree example from README to an optional plugin * Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858) * fix: restore Mason config timing for DAP startup (again) (nvim-lua#865) * Update README.md (nvim-lua#860) Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement. * Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869) * Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868) * Fix deprecation notice of inlay hints (nvim-lua#873) * Fix highlight errors when lsp crash or stop (nvim-lua#864) * Fix highlight errors when lsp crash or stop It adds a check wether the client is still available before highlighting. If the client is not there anymore it returns `true` to unregister the autocommand This fix the `method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer` errors when doing a LspRestart or the server crashes * Delete the highlight autocommands in the LspDetatch event * Only delete autocmds for the current buffer with the group name * Simplify clearing the autocommands --------- Co-authored-by: Francis Belanger <[email protected]> * fix: highlight group clear on each attach (nvim-lua#874) * Update README.md (nvim-lua#875) Line 102. Placed 'also' before the 'includes'. "That includes also examples of adding popularly requested plugins." ---> "That also includes examples of adding popularly requested plugins." * README: add clipboard tool dependency (nvim-lua#886) Fixes: nvim-lua#884 Neovim requires an external tool for proper system clipboard integration. Some systems install this already by default: - on Fedora xsel is already installed by default - on Windows using the choko install the win32yank is alredy installed This is not installed by default on ubuntu or debian so adding that to the dependencies list and to the install instructions snippets. * Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900) Moved to make sure the kickstart-lsp-highlight group exists when the LspDetach handler is invoked. The LspDetach handler is used to clean up any lsp highlights that were enabled by CursorHold if the LSP is stopped or crashed. * Add diff to treesitter's ensure_installed languages (nvim-lua#908) * fix: debug.lua (nvim-lua#918) * Automatically set detached state as needed. (nvim-lua#925) * Automatically set detached state as needed. * Use vim.fn.has instead. * Fix int vs bool. * which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) * fix: update lazy uninstall information link (nvim-lua#1148) * Disable linting autocmd for readonly buffers (nvim-lua#1202) * Disable linting autocmd for readonly buffers This should avoid linting in buffers outside of the user's control, having in mind especially the handy LSP pop-ups that describe your hovered symbol using markdown. Co-authored-by: Robin Gruyters <[email protected]> * Justify guarding try_lint in readonly buffers Co-authored-by: Robin Gruyters <[email protected]> --------- Co-authored-by: Robin Gruyters <[email protected]> * samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) * samarth-nagar fix: lazy help tag on line 931 found in issue nvim-lua#1152 * fixed white space --------- Co-authored-by: sam <[email protected]> * Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) * feat: Change diagnostic symbols if vim.g.have_nerd_font is true * feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Set breakpoint icons and their highlight colors (nvim-lua#1194) * feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Remove two because there are more than two. (nvim-lua#1213) * feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) * Fix nvim-dap not lazy loading (nvim-lua#1216) * Fix nvim-dap not lazy loading The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading. Fixed this by changing keys to a table and substituting the local variables with a lamba function * Make debug keybind descriptions more consistent * fix: which-key comment typo (nvim-lua#1227) * Tweak outdated comment about lazy's `config` key usage. (nvim-lua#1250) Remove outdated comment describing use of `config` key, replacing with corrected `opt` key note. Fixes nvim-lua#1249 * Use consistent syntax style for { ... } "pseudocode" (nvim-lua#1247) ``` require('gitsigns').setup({ ... }) ``` This was the first occurrence It may be nice to have the same style everywhere Cosmetic change (just to make docs/comments even more perfect) * Issue 1249 which key comments (nvim-lua#1263) * Tweak outdated comment about lazy's `config` key usage. Remove outdated comment describing use of `config` key, replacing with corrected `opt` key note. Fixes nvim-lua#1249 * fix typo opt -> opts Fixes nvim-lua#1250 * fix(gitsigns): make visual mode descriptions consistent with normal mode (nvim-lua#1266) * Fix README.md grammar and typos (nvim-lua#1291) * chore: add pre-issue requirements (nvim-lua#1288) * chore: add pre-issue requirements Based on nvim-lua#1285 * docs: add header about documentation Based on nvim-lua#1285 * Fix which-key delay settings (nvim-lua#1276) The which-key plugin used to rely on vim.opt.timeoutlen, but it was updated a few months ago to use its own opt.delay instead. https://github.com/folke/which-key.nvim/blob/8ab96b38a2530eacba5be717f52e04601eb59326/NEWS.md?plain=1#L10 I set which-key's delay to 0 ms because it makes it feel snappy and responsive! That way, we give new users a good first impression. * fix: prevent mason setup from being run twice (nvim-lua#1298) * fix: prevent mason setup from being run twice Addresses nvim-lua#1297 Currently, we're calling `require('mason').setup(...)` twice: * once when setting it as a dependency of `nvim-lspconfig` (since we set `config = true`) * once in the `config` function we define for `nvim-lspconfig` Calling setup twice can cause issues with, e.g., setting the `PATH` option: you might append Mason's bin dir in one setup call and prepend it in the other. We've kept the setup of `mason` in the `nvim-lspconfig` dependencies table since leaving it to the `config` function caused some plugin-loading-order related issues in the past. See: * nvim-lua#210 * nvim-lua#554 * nvim-lua#555 * nvim-lua#865 * docs: tweak comments per review feedback * chore: remove redundant comment (nvim-lua#1307) * chore: fix typo in bug report issue template (nvim-lua#1306) * Use luals 3rd library for luv (nvim-lua#1303) * chore(docs): Update README.md (nvim-lua#1344) Neovim has renamed the "linux64" binary to "linux-x86_64". * docs: clarify using opts = {} vs config = function() ... require('plu… (nvim-lua#1316) * docs: clarify using opts = {} vs config = function() ... require('plugin').setup({}) .. end The current documentation mentioning that using "require" is equivalent to using "opts" without detailing the use in the "config = function()" block seems inaccurate. Lower in the configuration the "config = function()" block is used without clarifying why it needed and what it does. This clarification may help new users understand the difference between the two, or how and where to place the "require" statement. * Update init.lua * remove whitespace * fix (nvim-lua#1319): gitsigns deprecated functions (nvim-lua#1321) - This commit change two functions that are marked as deprecated now: `gitsigns.stage_hunk` and `gitsigns.toggle_deleted` * Add a blurb about installing missing emoji on Ubuntu Right next to the nerdfonts blurb as requested. * fix: arguments for the `vim.lsp.Client.supports_method` method (nvim-lua#1356) * feat(diagnostic): add diagnostic config (nvim-lua#1335) Co-authored-by: gelocraft <[email protected]> * perf: load tokyonight.nvim in the intended way (nvim-lua#1360) Fixes nvim-lua#1357 * feat: add basic function signature help (nvim-lua#1358) * feat: add basic function signature help * Update init.lua Co-authored-by: makeworld <[email protected]> --------- Co-authored-by: makeworld <[email protected]> * Fix: fix the cmp-nvim-lsp-signature-help link (nvim-lua#1363) * fix: regression introduced in db78c0b (nvim-lua#1367) * Remove duplicate cmp-path (nvim-lua#1369) * Propsed fix for init.lua warnings as per nvim-lua#1305 (comment) (nvim-lua#1354) --------- Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Chiller Dragon <[email protected]> Co-authored-by: Ryan Winchester <[email protected]> Co-authored-by: Nora Ayesha <[email protected]> Co-authored-by: name.tar.xz <[email protected]> Co-authored-by: Ryan Baumgardner <[email protected]> Co-authored-by: James Karefylakis <[email protected]> Co-authored-by: Chris Patti <[email protected]> Co-authored-by: TLW <[email protected]> Co-authored-by: Rafael Zasas <[email protected]> Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: stgpepper <[email protected]> Co-authored-by: Shane Crowley <[email protected]> Co-authored-by: Fredrik Averpil <[email protected]> Co-authored-by: Togglebit <[email protected]> Co-authored-by: José Miguel Sarasola <[email protected]> Co-authored-by: E <[email protected]> Co-authored-by: Liu Qisheng <[email protected]> Co-authored-by: Viet <[email protected]> Co-authored-by: rdvm <[email protected]> Co-authored-by: GameFuzzy <[email protected]> Co-authored-by: Evan Carroll <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Adolfo Gante <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Smig <[email protected]> Co-authored-by: Per Malmberg <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]> Co-authored-by: ben fleis <[email protected]> Co-authored-by: Artem Dragunov <[email protected]> Co-authored-by: Scott Swensen <[email protected]> Co-authored-by: George <[email protected]> Co-authored-by: Ryan Jensen <[email protected]> Co-authored-by: Tomas Gareau <[email protected]> Co-authored-by: Nhan Luu <[email protected]> Co-authored-by: Diorman Colmenares <[email protected]> Co-authored-by: Ryan Nevius <[email protected]> Co-authored-by: bleacheda <[email protected]> Co-authored-by: Erlan Rangel <[email protected]> Co-authored-by: Jonas Zeltner <[email protected]> Co-authored-by: GeloCraft <[email protected]> Co-authored-by: gelocraft <[email protected]> Co-authored-by: Joaquín Guerra <[email protected]> Co-authored-by: Rob <[email protected]> Co-authored-by: makeworld <[email protected]> Co-authored-by: Aryan Rajoria <[email protected]> Co-authored-by: Ari Pollak <[email protected]> Co-authored-by: Dor Simhon <[email protected]>

chore: remove redundant comment

7777fe5

BALAJI24092001 suggested changes Jan 14, 2025

View reviewed changes

BALAJI24092001 approved these changes Jan 15, 2025

View reviewed changes

feoh merged commit f6abf68 into nvim-lua:master Jan 15, 2025
1 check passed

insikl pushed a commit to insikl/dotfiles.nvim that referenced this pull request Jan 16, 2025

chore: remove redundant comment (nvim-lua#1307)

b71c8e0

Lwessel812 pushed a commit to Lwessel812/kickstart that referenced this pull request Jan 16, 2025

chore: remove redundant comment (nvim-lua#1307)

a5ca236

mrmarvmarvv pushed a commit to mrmarvmarvv/kickstart.nvim that referenced this pull request Jan 16, 2025

chore: remove redundant comment (nvim-lua#1307)

9674578

sfragis pushed a commit to sfragis/kickstart.nvim that referenced this pull request Jan 17, 2025

chore: remove redundant comment (nvim-lua#1307)

31e74b7

dribic pushed a commit to dribic/nvim-files that referenced this pull request Jan 19, 2025

chore: remove redundant comment (nvim-lua#1307)

f245fd1

Signed-off-by: Dejan Ribič <[email protected]>

na47io pushed a commit to na47io/kickstart.nvim that referenced this pull request Jan 21, 2025

chore: remove redundant comment (nvim-lua#1307)

122163a

chaimleib pushed a commit to chaimleib/kickstart.nvim that referenced this pull request Jan 24, 2025

chore: remove redundant comment (nvim-lua#1307)

b0224fd

nvim192 pushed a commit to nvim192/kickstart.nvim that referenced this pull request Jan 24, 2025

chore: remove redundant comment (nvim-lua#1307)

f00d29e

ottoreimers pushed a commit to ottoreimers/kickstart.nvim that referenced this pull request Jan 31, 2025

chore: remove redundant comment (nvim-lua#1307)

9750c5c

rodolfolabiapari pushed a commit to rodolfolabiapari/kickstart.nvim that referenced this pull request Jan 31, 2025

chore: remove redundant comment (nvim-lua#1307)

033a40e

johnlonganecker pushed a commit to johnlonganecker/kickstart.nvim that referenced this pull request Feb 2, 2025

chore: remove redundant comment (nvim-lua#1307)

e4f12b2

samiiali pushed a commit to samiiali/kickstart.nvim that referenced this pull request Feb 3, 2025

chore: remove redundant comment (nvim-lua#1307)

6466225

kevinlangmade pushed a commit to kevinlangmade/kickstart.nvim that referenced this pull request Feb 4, 2025

chore: remove redundant comment (nvim-lua#1307)

d2d120b

alinsalaru pushed a commit to alinsalaru/kickstart.nvim that referenced this pull request Feb 5, 2025

chore: remove redundant comment (nvim-lua#1307)

c760bc4

Fepozopo pushed a commit to Fepozopo/kickstart.nvim that referenced this pull request Feb 7, 2025

chore: remove redundant comment (nvim-lua#1307)

5e68802

kiritowu pushed a commit to kiritowu/kickstart.nvim that referenced this pull request Feb 11, 2025

chore: remove redundant comment (nvim-lua#1307)

e562030

RockBacon9922 pushed a commit to RockBacon9922/nvim that referenced this pull request Feb 12, 2025

chore: remove redundant comment (nvim-lua#1307)

8117867

atetz pushed a commit to atetz/kickstart.nvim that referenced this pull request Feb 13, 2025

chore: remove redundant comment (nvim-lua#1307)

af64223

nikhil-vemula pushed a commit to nikhil-vemula/kickstart.nvim that referenced this pull request Feb 16, 2025

chore: remove redundant comment (nvim-lua#1307)

875f5b4

ditatompel added a commit to ditatompel/ditatompel that referenced this pull request Feb 19, 2025

p50(nvim): remove redundant comment

6203256

This is a duplicate comment as it's already mentioned in the mason part. See: nvim-lua/kickstart.nvim#1307 Co-authored-by: Nhan Luu <[email protected]>

petalas pushed a commit to petalas/nvim that referenced this pull request Feb 19, 2025

chore: remove redundant comment (nvim-lua#1307)

5113ab1

petalas pushed a commit to petalas/nvim that referenced this pull request Feb 19, 2025

chore: remove redundant comment (nvim-lua#1307)

273075a

Alessandro201 pushed a commit to Alessandro201/kickstart.nvim that referenced this pull request Feb 19, 2025

chore: remove redundant comment (nvim-lua#1307)

28ada5b

charamzic pushed a commit to charamzic/kickstart.nvim that referenced this pull request Feb 19, 2025

chore: remove redundant comment (nvim-lua#1307)

5a8b495

rvonhoog pushed a commit to rvonhoog/kickstart.nvim that referenced this pull request Feb 24, 2025

chore: remove redundant comment (nvim-lua#1307)

e9d5168

shrkamat pushed a commit to shrkamat/kickstart.nvim that referenced this pull request Feb 27, 2025

chore: remove redundant comment (nvim-lua#1307)

81cb6ad

johanvaneck mentioned this pull request Mar 2, 2025

nvim lua/master johanvaneck/kickstart.nvim#2

Merged

cezarmathe pushed a commit to cezarmathe/kickstart.nvim that referenced this pull request Mar 2, 2025

chore: remove redundant comment (nvim-lua#1307)

04307ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove redundant comment #1307

chore: remove redundant comment #1307

nhld commented Jan 13, 2025

BALAJI24092001 left a comment

nhld commented Jan 15, 2025

chore: remove redundant comment #1307

chore: remove redundant comment #1307

Conversation

nhld commented Jan 13, 2025

BALAJI24092001 left a comment

Choose a reason for hiding this comment

nhld commented Jan 15, 2025