Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp #1042

jstrot · 2024-07-22T04:01:16Z

The plugin spec for neovim/nvim-lspconfig does a require('cmp_nvim_lsp') in the LspAttach event handler but does not explicitly add a dependency on hrsh7th/cmp-nvim-lsp.

This is fine in the default kickstart.nvim layout but may not work if someone decides to break the specs into separate folders or decides to remove/disable nvim-cmp.

This PR simply adds the explicit dependency where used.

shaoyanji

I don't know how this was deleted in the first place

iton0 · 2024-07-23T23:33:43Z

Should the cmp-nvim-lsp dependency be removed from the nvim-cmp setup?

feoh · 2024-07-28T16:53:14Z

I'm seeing lots of questions here and not many answers.

@jstrot thanks for your contribution, could you please respond to some of these comments? Happy to merge this if we can get consensus around what will work.

jstrot · 2024-07-28T22:47:58Z

I don't know how this was deleted in the first place

I think it's been missing since day-1 (4c4096c).
When plugins are initialized in a specific order (like a monolithic init.lua does), the dependency is already loaded. The issue arises if someone splits apart the config into separate files, e.g, lua/plugin/*.lua.

jstrot · 2024-07-28T22:54:17Z

Should the cmp-nvim-lsp dependency be removed from the nvim-cmp setup?

The issue I'm addressing is neovim/nvim-lspconfig missing a dependency on hrsh7th/cmp-nvim-lsp since neovim/nvim-lspconfig's config function there's a call to require('cmp_nvim_lsp')

As for nvim-cmp itself, once of the sources is "nvim_lsp" so its dependency on cmp-nvim-lsp should be kept.

…ip-nvim-lspconfig-dep-cmp-nvim-lsp

jstrot · 2024-07-28T22:58:21Z

I'm seeing lots of questions here and not many answers.

@jstrot thanks for your contribution, could you please respond to some of these comments? Happy to merge this if we can get consensus around what will work.

Sorry for taking time to respond, I hardly get time during the week...
I'm happy to answer further questions and comments.

Thanks.

iton0 · 2024-07-28T23:47:53Z

Should the cmp-nvim-lsp dependency be removed from the nvim-cmp setup?

The issue I'm addressing is neovim/nvim-lspconfig missing a dependency on hrsh7th/cmp-nvim-lsp since neovim/nvim-lspconfig's config function there's a call to require('cmp_nvim_lsp')

As for nvim-cmp itself, once of the sources is "nvim_lsp" so its dependency on cmp-nvim-lsp should be kept.

I thought that if the LSP config loads before the nvim-cmp plugin, the cmp-nvim-lsp should be available in the nvim-cmp setup. If so, is an explicit dependency needed in the nvim-cmp setup?

)

* master: Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) Remove treesitter prefer_git option (nvim-lua#1061)

* Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) --------- Co-authored-by: jstrot <[email protected]> Co-authored-by: Damjan 9000 <[email protected]>

References: nvim-lua/kickstart.nvim#1042 Signed-off-by: Fletcher Nichol <[email protected]>

)

References: nvim-lua/kickstart.nvim#1042 Signed-off-by: Fletcher Nichol <[email protected]>

)

* upstream/master: (55 commits) Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) fix: remove deprecated opt for conform.nvim (nvim-lua#1070) Fix: updated the windows installation commands (nvim-lua#1101) Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) refactor: update treesitter and which-key config (nvim-lua#1068) Check for loop or uv for lazypath (nvim-lua#1095) Add note in README about lazy-lock.json (nvim-lua#1090) Update README.md (nvim-lua#1091) Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) Remove treesitter prefer_git option (nvim-lua#1061) performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) Remove redundant hlsearch option (nvim-lua#1058) Update comment about the toggle inlay hints keymap (nvim-lua#1041) lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) Neovim 0.10 updates (nvim-lua#936) ...

)

@VlaDexa

* Add nvim-nio as dependency for nvim-dap-ui (nvim-lua#774) It's a dependency now * Update README.md (nvim-lua#781) The recommended step of forking the repo coming sequentially after the step instructing users to clone the current repo doesn't make sense. This commit orders the install instructions in a manner that's more logical. * README: wrap long lines (nvim-lua#784) * fix nvim-lua#799 (nvim-lua#800) Add `'luadoc'`, to the `ensure_installed` of `nvim-treesitter/nvim-treesitter` * Add instructions to quit :lazy. Fixes nvim-lua#761 * Add a keymap space-f to format buffer using conform (nvim-lua#817) This works also for visual range selection Copied from conform recipe: https://github.com/stevearc/conform.nvim/blob/master/doc/recipes.md * Don't lazy load conform plugin (nvim-lua#818) * README: move backup and paths from external deps to install section (nvim-lua#819) * Add a pull request template (nvim-lua#825) * Update README (nvim-lua#832) * Arch, btw (nvim-lua#852) * Arch, btw * Add unzip * Add unzip for Fedora and --needed arg for Arch * Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854) * Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856) * Enable inlay hints for the supporting servers (nvim-lua#843) * Move plugin examples from README to optional plugin files (nvim-lua#831) * Move autopairs example from README to an optional plugin * Move neo-tree example from README to an optional plugin * Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858) * fix: restore Mason config timing for DAP startup (again) (nvim-lua#865) * Update README.md (nvim-lua#860) Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement. * Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869) * Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868) * Fix deprecation notice of inlay hints (nvim-lua#873) * Fix highlight errors when lsp crash or stop (nvim-lua#864) * Fix highlight errors when lsp crash or stop It adds a check wether the client is still available before highlighting. If the client is not there anymore it returns `true` to unregister the autocommand This fix the `method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer` errors when doing a LspRestart or the server crashes * Delete the highlight autocommands in the LspDetatch event * Only delete autocmds for the current buffer with the group name * Simplify clearing the autocommands --------- Co-authored-by: Francis Belanger <[email protected]> * fix: highlight group clear on each attach (nvim-lua#874) * Update README.md (nvim-lua#875) Line 102. Placed 'also' before the 'includes'. "That includes also examples of adding popularly requested plugins." ---> "That also includes examples of adding popularly requested plugins." * README: add clipboard tool dependency (nvim-lua#886) Fixes: nvim-lua#884 Neovim requires an external tool for proper system clipboard integration. Some systems install this already by default: - on Fedora xsel is already installed by default - on Windows using the choko install the win32yank is alredy installed This is not installed by default on ubuntu or debian so adding that to the dependencies list and to the install instructions snippets. * Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900) Moved to make sure the kickstart-lsp-highlight group exists when the LspDetach handler is invoked. The LspDetach handler is used to clean up any lsp highlights that were enabled by CursorHold if the LSP is stopped or crashed. * Add diff to treesitter's ensure_installed languages (nvim-lua#908) * fix: debug.lua (nvim-lua#918) * Automatically set detached state as needed. (nvim-lua#925) * Automatically set detached state as needed. * Use vim.fn.has instead. * Fix int vs bool. * which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. --------- Co-authored-by: José Miguel Sarasola <[email protected]> Co-authored-by: E <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Liu Qisheng <[email protected]> Co-authored-by: Chris Patti <[email protected]> Co-authored-by: Viet <[email protected]> Co-authored-by: rdvm <[email protected]> Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: GameFuzzy <[email protected]> Co-authored-by: Evan Carroll <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Adolfo Gante <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Smig <[email protected]> Co-authored-by: Per Malmberg <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]>

)

@VlaDexa

* Arch, btw (nvim-lua#852) * Arch, btw * Add unzip * Add unzip for Fedora and --needed arg for Arch * Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854) * Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856) * Enable inlay hints for the supporting servers (nvim-lua#843) * Move plugin examples from README to optional plugin files (nvim-lua#831) * Move autopairs example from README to an optional plugin * Move neo-tree example from README to an optional plugin * Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858) * fix: restore Mason config timing for DAP startup (again) (nvim-lua#865) * Update README.md (nvim-lua#860) Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement. * Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869) * Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868) * Fix deprecation notice of inlay hints (nvim-lua#873) * Fix highlight errors when lsp crash or stop (nvim-lua#864) * Fix highlight errors when lsp crash or stop It adds a check wether the client is still available before highlighting. If the client is not there anymore it returns `true` to unregister the autocommand This fix the `method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer` errors when doing a LspRestart or the server crashes * Delete the highlight autocommands in the LspDetatch event * Only delete autocmds for the current buffer with the group name * Simplify clearing the autocommands --------- Co-authored-by: Francis Belanger <[email protected]> * fix: highlight group clear on each attach (nvim-lua#874) * Update README.md (nvim-lua#875) Line 102. Placed 'also' before the 'includes'. "That includes also examples of adding popularly requested plugins." ---> "That also includes examples of adding popularly requested plugins." * README: add clipboard tool dependency (nvim-lua#886) Fixes: nvim-lua#884 Neovim requires an external tool for proper system clipboard integration. Some systems install this already by default: - on Fedora xsel is already installed by default - on Windows using the choko install the win32yank is alredy installed This is not installed by default on ubuntu or debian so adding that to the dependencies list and to the install instructions snippets. * Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900) Moved to make sure the kickstart-lsp-highlight group exists when the LspDetach handler is invoked. The LspDetach handler is used to clean up any lsp highlights that were enabled by CursorHold if the LSP is stopped or crashed. * Add diff to treesitter's ensure_installed languages (nvim-lua#908) * fix: debug.lua (nvim-lua#918) * Automatically set detached state as needed. (nvim-lua#925) * Automatically set detached state as needed. * Use vim.fn.has instead. * Fix int vs bool. * which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) --------- Co-authored-by: rdvm <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Chris Patti <[email protected]> Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: GameFuzzy <[email protected]> Co-authored-by: Evan Carroll <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Adolfo Gante <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Smig <[email protected]> Co-authored-by: Per Malmberg <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]>

)

@VlaDexa

* Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) * fix: update lazy uninstall information link (nvim-lua#1148) * Disable linting autocmd for readonly buffers (nvim-lua#1202) * Disable linting autocmd for readonly buffers This should avoid linting in buffers outside of the user's control, having in mind especially the handy LSP pop-ups that describe your hovered symbol using markdown. Co-authored-by: Robin Gruyters <[email protected]> * Justify guarding try_lint in readonly buffers Co-authored-by: Robin Gruyters <[email protected]> --------- Co-authored-by: Robin Gruyters <[email protected]> * samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) * samarth-nagar fix: lazy help tag on line 931 found in issue nvim-lua#1152 * fixed white space --------- Co-authored-by: sam <[email protected]> * Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) * feat: Change diagnostic symbols if vim.g.have_nerd_font is true * feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Set breakpoint icons and their highlight colors (nvim-lua#1194) * feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Remove two because there are more than two. (nvim-lua#1213) * feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) * Fix nvim-dap not lazy loading (nvim-lua#1216) * Fix nvim-dap not lazy loading The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading. Fixed this by changing keys to a table and substituting the local variables with a lamba function * Make debug keybind descriptions more consistent * fix: which-key comment typo (nvim-lua#1227) --------- Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]>

@VlaDexa

* which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) * fix: update lazy uninstall information link (nvim-lua#1148) * Disable linting autocmd for readonly buffers (nvim-lua#1202) * Disable linting autocmd for readonly buffers This should avoid linting in buffers outside of the user's control, having in mind especially the handy LSP pop-ups that describe your hovered symbol using markdown. Co-authored-by: Robin Gruyters <[email protected]> * Justify guarding try_lint in readonly buffers Co-authored-by: Robin Gruyters <[email protected]> --------- Co-authored-by: Robin Gruyters <[email protected]> * samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) * samarth-nagar fix: lazy help tag on line 931 found in issue nvim-lua#1152 * fixed white space --------- Co-authored-by: sam <[email protected]> * Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) * feat: Change diagnostic symbols if vim.g.have_nerd_font is true * feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Set breakpoint icons and their highlight colors (nvim-lua#1194) * feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Remove two because there are more than two. (nvim-lua#1213) * feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) * Fix nvim-dap not lazy loading (nvim-lua#1216) * Fix nvim-dap not lazy loading The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading. Fixed this by changing keys to a table and substituting the local variables with a lamba function * Make debug keybind descriptions more consistent * fix: which-key comment typo (nvim-lua#1227) --------- Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]> Co-authored-by: mogz <[email protected]>

* upstream/master: (39 commits) fix: which-key comment typo (nvim-lua#1227) Fix nvim-dap not lazy loading (nvim-lua#1216) feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) Remove two because there are more than two. (nvim-lua#1213) Set breakpoint icons and their highlight colors (nvim-lua#1194) Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) Disable linting autocmd for readonly buffers (nvim-lua#1202) fix: update lazy uninstall information link (nvim-lua#1148) feat: update references of tsserver to ts_ls (nvim-lua#1131) Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) fix: remove deprecated opt for conform.nvim (nvim-lua#1070) Fix: updated the windows installation commands (nvim-lua#1101) Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) refactor: update treesitter and which-key config (nvim-lua#1068) Check for loop or uv for lazypath (nvim-lua#1095) Add note in README about lazy-lock.json (nvim-lua#1090) Update README.md (nvim-lua#1091) Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) Remove treesitter prefer_git option (nvim-lua#1061) performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) Remove redundant hlsearch option (nvim-lua#1058) Update comment about the toggle inlay hints keymap (nvim-lua#1041) lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) Neovim 0.10 updates (nvim-lua#936) ...

)

@VlaDexa

* which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. * feat: update references of tsserver to ts_ls (nvim-lua#1131) * fix: update lazy uninstall information link (nvim-lua#1148) * Disable linting autocmd for readonly buffers (nvim-lua#1202) * Disable linting autocmd for readonly buffers This should avoid linting in buffers outside of the user's control, having in mind especially the handy LSP pop-ups that describe your hovered symbol using markdown. Co-authored-by: Robin Gruyters <[email protected]> * Justify guarding try_lint in readonly buffers Co-authored-by: Robin Gruyters <[email protected]> --------- Co-authored-by: Robin Gruyters <[email protected]> * samarth-nagar fix: lazy help tag on line 931 (nvim-lua#1167) * samarth-nagar fix: lazy help tag on line 931 found in issue nvim-lua#1152 * fixed white space --------- Co-authored-by: sam <[email protected]> * Change diagnostic symbols if vim.g.have_nerd_font is true (nvim-lua#1195) * feat: Change diagnostic symbols if vim.g.have_nerd_font is true * feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Set breakpoint icons and their highlight colors (nvim-lua#1194) * feat: Set breakpoint icons and their highlight colors * docs: Delete reference URL (written in PR) feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so --------- Co-authored-by: name <email> * Remove two because there are more than two. (nvim-lua#1213) * feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define() (nvim-lua#1232) * Fix nvim-dap not lazy loading (nvim-lua#1216) * Fix nvim-dap not lazy loading The keys property had local variables 'dap' and 'dap-ui' that used `require` and prevented all DAP related plugins from lazy-loading. Fixed this by changing keys to a table and substituting the local variables with a lamba function * Make debug keybind descriptions more consistent * fix: which-key comment typo (nvim-lua#1227) --------- Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]> Co-authored-by: Nicolás Baquero <[email protected]> Co-authored-by: Bastien Traverse <[email protected]> Co-authored-by: Éric NICOLAS <[email protected]> Co-authored-by: Robin Gruyters <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: sam <[email protected]> Co-authored-by: gloomy-lemon-debatable <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Anjishnu Banerjee <[email protected]> Co-authored-by: Miha <[email protected]> Co-authored-by: mogz <[email protected]>

@VlaDexa

* Add nvim-nio as dependency for nvim-dap-ui (nvim-lua#774) It's a dependency now * Update README.md (nvim-lua#781) The recommended step of forking the repo coming sequentially after the step instructing users to clone the current repo doesn't make sense. This commit orders the install instructions in a manner that's more logical. * README: wrap long lines (nvim-lua#784) * fix nvim-lua#799 (nvim-lua#800) Add `'luadoc'`, to the `ensure_installed` of `nvim-treesitter/nvim-treesitter` * Add instructions to quit :lazy. Fixes nvim-lua#761 * Add a keymap space-f to format buffer using conform (nvim-lua#817) This works also for visual range selection Copied from conform recipe: https://github.com/stevearc/conform.nvim/blob/master/doc/recipes.md * Don't lazy load conform plugin (nvim-lua#818) * README: move backup and paths from external deps to install section (nvim-lua#819) * Add a pull request template (nvim-lua#825) * Update README (nvim-lua#832) * Arch, btw (nvim-lua#852) * Arch, btw * Add unzip * Add unzip for Fedora and --needed arg for Arch * Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854) * Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856) * Enable inlay hints for the supporting servers (nvim-lua#843) * Move plugin examples from README to optional plugin files (nvim-lua#831) * Move autopairs example from README to an optional plugin * Move neo-tree example from README to an optional plugin * Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858) * fix: restore Mason config timing for DAP startup (again) (nvim-lua#865) * Update README.md (nvim-lua#860) Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement. * Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869) * Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868) * Fix deprecation notice of inlay hints (nvim-lua#873) * Fix highlight errors when lsp crash or stop (nvim-lua#864) * Fix highlight errors when lsp crash or stop It adds a check wether the client is still available before highlighting. If the client is not there anymore it returns `true` to unregister the autocommand This fix the `method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer` errors when doing a LspRestart or the server crashes * Delete the highlight autocommands in the LspDetatch event * Only delete autocmds for the current buffer with the group name * Simplify clearing the autocommands --------- Co-authored-by: Francis Belanger <[email protected]> * fix: highlight group clear on each attach (nvim-lua#874) * Update README.md (nvim-lua#875) Line 102. Placed 'also' before the 'includes'. "That includes also examples of adding popularly requested plugins." ---> "That also includes examples of adding popularly requested plugins." * README: add clipboard tool dependency (nvim-lua#886) Fixes: nvim-lua#884 Neovim requires an external tool for proper system clipboard integration. Some systems install this already by default: - on Fedora xsel is already installed by default - on Windows using the choko install the win32yank is alredy installed This is not installed by default on ubuntu or debian so adding that to the dependencies list and to the install instructions snippets. * Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900) Moved to make sure the kickstart-lsp-highlight group exists when the LspDetach handler is invoked. The LspDetach handler is used to clean up any lsp highlights that were enabled by CursorHold if the LSP is stopped or crashed. * Add diff to treesitter's ensure_installed languages (nvim-lua#908) * fix: debug.lua (nvim-lua#918) * Automatically set detached state as needed. (nvim-lua#925) * Automatically set detached state as needed. * Use vim.fn.has instead. * Fix int vs bool. * which-key v3 update (nvim-lua#1022) * which-key v3 update * remove unneeded brackets from which-key registration * fix(lazy): added error handling for bootstrap (nvim-lua#1001) * fix: add required parsers from nvim-treesitter * Fix neo-tree keymap description (nvim-lua#932) The lazy.nvim keys parameter does not need the `desc` to be inside a table in the way that vim.keymap.set() does. With this fix the keymap description will be properly shown for example in telescope keymap search * Remove redundant require (nvim-lua#959) * Make debug lazy loadable (nvim-lua#978) * Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963) - Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully` * Make conform.nvim be lazy-loadable again (nvim-lua#977) The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being loaded before write. This sets up lazy to load conform before write. * Fix comment about mini.ai example (nvim-lua#985) This example wasn't using `'` so this makes more sense * Neovim 0.10 updates (nvim-lua#936) * Neovim 0.10 updates Provide the buffer for which to enable inlay hints Co-authored-by: Matt Mirus <[email protected]> * refactor: replace vim.loop with vim.uv * Upgrade folke/neodev (sunsetting) to folke/lazydev * Update checkhealth for 0.10 release --------- Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> * Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040) 7513ec8 switched from neodev to lazydev, but in the process it introduced an LSP error in `init.lua`, which degrades the desired "first timer" experience of kickstart.nvim. This commit follows the configuration suggested in https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation which resolves the LSP error. * lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947) * fix: lsp warning * review suggestion Co-authored-by: Tom Kuson <[email protected]> --------- Co-authored-by: Tom Kuson <[email protected]> * Update comment about the toggle inlay hints keymap (nvim-lua#1041) * Remove redundant hlsearch option (nvim-lua#1058) * Modify conform comments to prevent deprecation warning when used (nvim-lua#1057) * refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047) * performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049) * Remove treesitter prefer_git option (nvim-lua#1061) - It's not safe and can corrupt other git repos - nvim-treesiter maintainers consider `prefer_git` as deprecated and no longer needed. See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959 * Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042) * Update README.md (nvim-lua#1091) * Add note in README about lazy-lock.json (nvim-lua#1090) * Check for loop or uv for lazypath (nvim-lua#1095) * refactor: update treesitter and which-key config (nvim-lua#1068) * Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064) * Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108) * Fix: updated the windows installation commands (nvim-lua#1101) * Update README.md * Update README.md * Fix: updated the windows installation commands * fix: remove deprecated opt for conform.nvim (nvim-lua#1070) - changed lsp_fallback -> lsp_format - updated format_on_save function to reflect change above * cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102) - Moved `which-key` configuration from inline `config` to `opts` for better organization. - Updated the key mappings setup to use `spec` for defining existing key chains. - Removed deprecated or unnecessary comments and code. This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068. * Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113) The recent cleanup accidentally broke the leader key specs because the spec block was in the wrong level of braces. That resulted in which-key no longer showing the description of the <leader> key chains such as [S]earch and others. --------- Co-authored-by: José Miguel Sarasola <[email protected]> Co-authored-by: E <[email protected]> Co-authored-by: Damjan 9000 <[email protected]> Co-authored-by: Liu Qisheng <[email protected]> Co-authored-by: Chris Patti <[email protected]> Co-authored-by: Viet <[email protected]> Co-authored-by: rdvm <[email protected]> Co-authored-by: Vladislav Grechannik <[email protected]> Co-authored-by: GameFuzzy <[email protected]> Co-authored-by: Evan Carroll <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Francis Belanger <[email protected]> Co-authored-by: Adolfo Gante <[email protected]> Co-authored-by: Richard Macklin <[email protected]> Co-authored-by: Smig <[email protected]> Co-authored-by: Per Malmberg <[email protected]> Co-authored-by: Folke Lemaitre <[email protected]> Co-authored-by: TJ DeVries <[email protected]> Co-authored-by: Tom Kuson <[email protected]> Co-authored-by: Artyom <[email protected]> Co-authored-by: Matt Mirus <[email protected]> Co-authored-by: mrr11k <[email protected]> Co-authored-by: Seb Tomasini <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Arvin Verain <[email protected]> Co-authored-by: Brandon Clark <[email protected]> Co-authored-by: Ihsan Tonuzi <[email protected]> Co-authored-by: abeldekat <[email protected]> Co-authored-by: jstrot <[email protected]> Co-authored-by: theoboldalex <[email protected]> Co-authored-by: Matt Gallagher <[email protected]> Co-authored-by: Michael L. <[email protected]> Co-authored-by: Bayram Kazik <[email protected]> Co-authored-by: Harshit Pant <[email protected]>

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp

1201de6

shaoyanji approved these changes Jul 23, 2024

View reviewed changes

Merge branch 'master' of github.com:nvim-lua/kickstart.nvim into qual…

6c815d5

…ip-nvim-lspconfig-dep-cmp-nvim-lsp

feoh merged commit 1860184 into nvim-lua:master Jul 30, 2024
1 check passed

janmarthedal pushed a commit to janmarthedal/kickstart.nvim that referenced this pull request Jul 30, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

1dc6764

)

fnichol added a commit to fnichol/dotneovim that referenced this pull request Aug 1, 2024

fix: add cmp-nvim-lsp as dep to nvim-lspconfig

7aeda49

References: nvim-lua/kickstart.nvim#1042 Signed-off-by: Fletcher Nichol <[email protected]>

BartoszSadowski pushed a commit to BartoszSadowski/kickstart.nvim that referenced this pull request Aug 2, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

9119251

)

cjwright83 pushed a commit to cjwright83/kickstart.nvim that referenced this pull request Aug 6, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

6a9cee5

)

fnichol added a commit to fnichol/dotneovim that referenced this pull request Aug 6, 2024

fix: add cmp-nvim-lsp as dep to nvim-lspconfig

82adf31

References: nvim-lua/kickstart.nvim#1042 Signed-off-by: Fletcher Nichol <[email protected]>

hundrog pushed a commit to hundrog/kickstart.nvim that referenced this pull request Aug 9, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

81a2c49

)

melito00 pushed a commit to melito00/kickstart.nvim that referenced this pull request Aug 10, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

945854c

)

lepa22 pushed a commit to lepa22/kickstart-modular.nvim that referenced this pull request Aug 13, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

84f3800

)

academician pushed a commit to academician/kickstart.nvim that referenced this pull request Aug 14, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

e21eff6

)

ElMikosch pushed a commit to ElMikosch/nvim that referenced this pull request Aug 15, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

d88bd00

)

blerou pushed a commit to blerou/kickstart.nvim that referenced this pull request Aug 22, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

7a5e29f

)

JustinRyanH pushed a commit to JustinRyanH/kickstart.nvim that referenced this pull request Aug 24, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

f1d225b

)

benyamins pushed a commit to benyamins/kickstart.nvim that referenced this pull request Aug 25, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

5b1faf9

)

ldraney pushed a commit to ldraney/kickstart.nvim that referenced this pull request Aug 27, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

9ee737c

)

m-murphy pushed a commit to m-murphy/kickstart.nvim that referenced this pull request Sep 4, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

b25d411

)

marijnMeerveld pushed a commit to marijnMeerveld/kickstart.nvim that referenced this pull request Sep 5, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

dd85091

)

yulqen pushed a commit to yulqen/kickstart.nvim that referenced this pull request Sep 9, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

a890a1f

)

khsoh pushed a commit to khsoh/kickstart.nvim that referenced this pull request Sep 12, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

ea0198d

)

angerborn pushed a commit to angerborn/kickstart.nvim that referenced this pull request Sep 12, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

0030b2d

)

kpollich pushed a commit to kpollich/kickstart.nvim that referenced this pull request Sep 13, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

6be97de

)

eng-alecrim pushed a commit to eng-alecrim/kickstart.nvim that referenced this pull request Sep 16, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

0521d49

)

mynever pushed a commit to mynever/kickstart.nvim that referenced this pull request Sep 20, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

874b912

)

DougAnTr pushed a commit to DougAnTr/nvim that referenced this pull request Sep 26, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

ca1244b

)

abenteuerzeit pushed a commit to abenteuerzeit/kickstart.nvim that referenced this pull request Sep 27, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

3983138

)

Lumonde-software pushed a commit to Lumonde-software/kickstart.nvim that referenced this pull request Sep 29, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

52ebe56

)

diegorodriguezv pushed a commit to diegorodriguezv/kickstart.nvim that referenced this pull request Oct 1, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

e7ba915

)

umairraza96 pushed a commit to umairraza96/kickstart.nvim that referenced this pull request Oct 5, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

5018048

)

hchienjo pushed a commit to hchienjo/kickstart.nvim that referenced this pull request Oct 19, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

7aacb15

)

frankstutz pushed a commit to frankstutz/kickstart.nvim that referenced this pull request Oct 24, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

ca0e353

)

whalderman pushed a commit to whalderman/kickstart.nvim that referenced this pull request Nov 3, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

e7ac185

)

Livingpool pushed a commit to Livingpool/kickstart.nvim that referenced this pull request Nov 5, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

b0bb737

)

h4rldev pushed a commit to h4rldev/nvim that referenced this pull request Nov 8, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

13b8e7a

)

aadi123 pushed a commit to aadi123/kickstart.nvim that referenced this pull request Nov 17, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

a17f44a

)

victorqhong pushed a commit to victorqhong/nvim-config that referenced this pull request Dec 6, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

ead4386

)

burberrymyshirt mentioned this pull request Dec 7, 2024

update burberrymyshirt/kickstart-modular.nvim#1

Merged

gotocoffee1 pushed a commit to gotocoffee1/kickstart.nvim that referenced this pull request Dec 9, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

1a1ce45

)

rrcomtech pushed a commit to rrcomtech/neovim-config that referenced this pull request Dec 11, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

afaf7db

)

vivek-shrikhande pushed a commit to vivek-shrikhande/kickstart.nvim that referenced this pull request Dec 19, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

e0f60a2

)

flatplate pushed a commit to flatplate/kickstart.nvim that referenced this pull request Jan 2, 2025

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

2c11020

)

kontr0x pushed a commit to kontr0x/my-kickstart.nvim that referenced this pull request Jan 2, 2025

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042

c4a647d

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp #1042

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp #1042

jstrot commented Jul 22, 2024

shaoyanji left a comment

iton0 commented Jul 23, 2024

feoh commented Jul 28, 2024

jstrot commented Jul 28, 2024

jstrot commented Jul 28, 2024

jstrot commented Jul 28, 2024

iton0 commented Jul 28, 2024

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp #1042

Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp #1042

Conversation

jstrot commented Jul 22, 2024

shaoyanji left a comment

Choose a reason for hiding this comment

iton0 commented Jul 23, 2024

feoh commented Jul 28, 2024

jstrot commented Jul 28, 2024

jstrot commented Jul 28, 2024

jstrot commented Jul 28, 2024

iton0 commented Jul 28, 2024