-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bigger tap area, footer text links #742
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Could you reduce the size on desktop though @bdrtsky ? |
@atinux I prefer not to. First, it looks weird (the difference between mobile/desktop), second it brings additional complexity, since I had to use negative margin to align it with Container, since tap area padding breaks it in multiple places https://github.com/nuxt-themes/docus/pull/742/files#diff-68f900547074d9d200d4619f39ab6b539691bf6dd7408d0f123815b524c703efR94 With responsive changes I will need to change negative margins in multiple places as well, which brings ridiculous complexity to support those styles, with so much little profit (adding tap area was pretty much unnecessary in first place, but making it also responsive makes it even more) |
closes #726, closes #731