Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space in the footer for imprint #726

Closed
zoey-kaiser opened this issue Dec 14, 2022 · 6 comments · Fixed by #742
Closed

Add space in the footer for imprint #726

zoey-kaiser opened this issue Dec 14, 2022 · 6 comments · Fixed by #742

Comments

@zoey-kaiser
Copy link

Hello!

We are currently hosting our page in the EU, where it is required by law to have an imprint on your website. Sadly this link cannot be only an icon and must have the work "Imprint" available to read.

I attempted to add a extra link the footer, however the word imprint would just be cut off, as the space was made for icons.
I ended up having to replace the "Docus" branding text to have a link to our imprint.

Would it be possible to allow developers to add text based links into the footer or add a extra section in the footer for "legal stuff"?

Thanks!

Copy link
Contributor

atinux commented Dec 15, 2022

I think we can have a way to add links in the center of the footer, would that work?

@zoey-kaiser
Copy link
Author

I think we can have a way to add links in the center of the footer, would that work?

Yes, it would! Do you want me to open a PR and take a crack at it?

Copy link
Contributor

atinux commented Dec 19, 2022

First we can discuss about what would be the usage in the appConfig from your POV?

@zoey-kaiser
Copy link
Author

First we can discuss about what would be the usage in the appConfig from your POV?

Sure! My proposal would be to add it to the footer key in the appConfig. I would expect it to match the types of the iconLinks (icon, href, label). The key for these links would not be called iconLinks but centerLinks or textLinks, depending on what you prefer or think works best.

I could then get these values in the footer and display a max of 3? in the center with the icon being optional displayed on the left side of the text.

Next steps would be to make sure the footer still works on mobile devices and all viewports!

@bdrtsky
Copy link
Contributor

bdrtsky commented Dec 21, 2022

I would just add textLinks without option to have it with icon (hence the name).

@bdrtsky
Copy link
Contributor

bdrtsky commented Dec 21, 2022

This is what I have for desktop

Screenshot 2022-12-21 at 18 00 16

And this is default mobile

Screenshot 2022-12-21 at 17 59 06

But I would suggest to change the order a little bit, like

Screenshot 2022-12-21 at 17 59 23

Is this what you looking for @zoey-kaiser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants