Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size tap targets appropriately #731

Closed
harlan-zw opened this issue Dec 17, 2022 · 3 comments · Fixed by #742
Closed

Size tap targets appropriately #731

harlan-zw opened this issue Dec 17, 2022 · 3 comments · Fixed by #742
Assignees
@bdrtsky

Comments

@harlan-zw
Copy link
Collaborator

Issue

image

Reproduction

Run lighthouse on docus.dev.

Just need to make their paddings a bit bigger and maybe the icon size up a tiny bit
@atinux atinux assigned bdrtsky, antfu and atinux and unassigned antfu and atinux Dec 19, 2022
@bdrtsky
Copy link
Contributor

bdrtsky commented Dec 21, 2022 •
edited
Loading

if you follow those guides blindly, this is how UI will look in the end.

Screenshot 2022-12-21 at 13 58 58

Will add additional tap padding, but not sure about 48x48

@atinux Volta.net
Copy link
Contributor

atinux commented Dec 21, 2022

For mobile I guess it's fine, I don't see that very bad honestly

@bdrtsky bdrtsky mentioned this issue Dec 21, 2022
Merged
@harlan-zw
Copy link
Collaborator Author

harlan-zw commented Dec 21, 2022 •
edited
Loading

Ye only needed for mobile, it's something Google penalises for so probably worth fixing (mobile usability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdrtsky bdrtsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bigger tap area, footer text links nuxt-themes/docus
4 participants
@atinux @harlan-zw @antfu @bdrtsky