util: do not mark experimental feature as deprecated #55740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
legendecas
reviewed
Nov 6, 2024
There was a problem hiding this comment.
There were deprecations for experimental APIs like https://github.com/nodejs/node/blob/main/doc/api/deprecations.md#dep0173-the-assertcalltracker-class.
Maybe we could document that experimental APIs will not go through deprecation cycles?
RedYetiDev
added
experimental
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55740 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187747 187749 +2
Branches 36127 36131 +4
=======================================
+ Hits 165972 165977 +5
- Misses 15009 15012 +3
+ Partials 6766 6760 -6
|
SGTM |
legendecas
approved these changes
Nov 6, 2024
atlowChemi
approved these changes
Nov 7, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Nov 8, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 94be10a |
aduh95
added a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v22.x
aduh95
added a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
aduh95
added
backported-to-v22.x
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55740 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A deprecated API has stability guarantees that an experimental API does not. I don't think we should mark an experimental API as deprecated without first graduating it to stable. Instead we can emit an experimental warning which would tell the user the API was renamed.