Skip to content

Commit

Permalink
util: do not mark experimental feature as deprecated
Browse files Browse the repository at this point in the history
PR-URL: #55740
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
  • Loading branch information
aduh95 authored and ruyadorno committed Nov 27, 2024
1 parent f11d93d commit fce8c32
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 18 deletions.
14 changes: 1 addition & 13 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -3685,18 +3685,7 @@ Instantiating classes without the `new` qualifier exported by the `node:repl` mo
It is recommended to use the `new` qualifier instead. This applies to all REPL classes, including
`REPLServer` and `Recoverable`.

### DEP0186: `util.getCallSite`

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/55626
description: Runtime deprecation.
-->

Type: Runtime

The `util.getCallSite` API has been removed. Please use [`util.getCallSites()`][] instead.
<!-- md-lint skip-deprecation DEP0186 -->

[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
Expand Down Expand Up @@ -3824,7 +3813,6 @@ The `util.getCallSite` API has been removed. Please use [`util.getCallSites()`][
[`url.parse()`]: url.md#urlparseurlstring-parsequerystring-slashesdenotehost
[`url.resolve()`]: url.md#urlresolvefrom-to
[`util._extend()`]: util.md#util_extendtarget-source
[`util.getCallSites()`]: util.md#utilgetcallsitesframecount
[`util.getSystemErrorName()`]: util.md#utilgetsystemerrornameerr
[`util.inspect()`]: util.md#utilinspectobject-options
[`util.inspect.custom`]: util.md#utilinspectcustom
Expand Down
4 changes: 4 additions & 0 deletions doc/api/util.md
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,10 @@ util.formatWithOptions({ colors: true }, 'See object %O', { foo: 42 });
<!-- YAML
added: v22.9.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/55626
description: The API is renamed from `util.getCallSite` to `util.getCallSites()`.
-->

* `frameCount` {number} Number of frames to capture as call site objects.
Expand Down
4 changes: 3 additions & 1 deletion lib/internal/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ function getDeprecationWarningEmitter(
return function() {
if (!warned && shouldEmitWarning()) {
warned = true;
if (code !== undefined) {
if (code === 'ExperimentalWarning') {
process.emitWarning(msg, code, deprecated);
} else if (code !== undefined) {
if (!codesWarned.has(code)) {
const emitWarning = useEmitSync ?
require('internal/process/warning').emitWarningSync :
Expand Down
4 changes: 2 additions & 2 deletions lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -502,8 +502,8 @@ module.exports = {
// Deprecated getCallSite.
// This API can be removed in next semver-minor release.
getCallSite: deprecate(getCallSites,
'The `util.getCallSite` API is deprecated. Please use `util.getCallSites()` instead.',
'DEP0186'),
'The `util.getCallSite` API has been renamed to `util.getCallSites()`.',
'ExperimentalWarning'),
getCallSites,
getSystemErrorMap,
getSystemErrorName,
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-util-getcallsite.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ require('../common');
const { getCallSite } = require('node:util');
const { expectWarning } = require('../common');

const warning = 'The `util.getCallSite` API is deprecated. Please use `util.getCallSites()` instead.';
expectWarning('DeprecationWarning', warning, 'DEP0186');
const warning = 'The `util.getCallSite` API has been renamed to `util.getCallSites()`.';
expectWarning('ExperimentalWarning', warning);
getCallSite();

0 comments on commit fce8c32

Please sign in to comment.